Re: [Minios-devel] [UNIKRAFT/RUBY PATCH 10/16] extensions: Build extensions

[Costin Lupu <costin.lupu@xxxxxxxxx>]

On 12/11/19 5:14 PM, Stefan Teodorescu wrote:
> zlib extension should depend on LIBZLIB.
> 
> The last 3 extensions in Init_ext() function are misconfigured, as
> they are enabled for the flag CONFIG_LIBRUBY_EXT_RIPPER.
> Same for json (third one), which is enabled under CONFIG_LIBRUBY_EXT_SYSLOG.
> 

Right, good catch!

> Also, as discussed, since stringio is a mandatory extension, this
> extension initialization function should be called even when
> extensions are disabled, to call the init for stringio.

In deed, stringio is the only mandatory extension for ruby. However,
please keep in mind that miniruby doesn't use any extension at all.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel