Re: [Minios-devel] [UNIKRAFT/LIBLWIP PATCH v2 1/2] Add missing EAI_* macro definitions

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad, sounds good, I'll fix that on upstreaming, thanks.

-- Felipe

On 11.12.19, 00:18, "Minios-devel on behalf of Vlad-Andrei BĂDOIU (78692)" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    Hey,
    
    Actually there is a problem that may be fixed during the upstreaming, 
    please see inline.
    
    Thanks,
    
    Vlad
    
    On 09.12.2019 10:19, Felipe Huici wrote:
    > Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
    > ---
    >   include/netdb.h | 11 ++++++++++-
    >   1 file changed, 10 insertions(+), 1 deletion(-)
    >
    > diff --git a/include/netdb.h b/include/netdb.h
    > index 948a2e7..5bbd354 100644
    > --- a/include/netdb.h
    > +++ b/include/netdb.h
    > @@ -1,3 +1,5 @@
    > +#ifndef _LWIP_GLUE_NETDB_H_
    > +#define _LWIP_GLUE_NETDB_H_
    >   #include <compat/posix/netdb.h>
    >   
    >   #if LWIP_DNS && LWIP_SOCKET
    > @@ -63,7 +65,13 @@ void setprotoent(int stayopen);
    >   #define EAI_SYSTEM     11
    This definition should be removed since we're redefining the value again 
    at a future point in the code.
    >   
    >   /* Error values for getaddrinfo() not defined by lwip/netdb.h */
    > -#define EAI_OVERFLOW    205      /* Argument buffer overflow.  */
    > +#define EAI_BADFLAGS   -1
    > +#define EAI_AGAIN      -3
    > +#define EAI_NODATA     -5
    > +#define EAI_SOCKTYPE   -7
    > +#define EAI_ADDRFAMILY -9
    > +#define EAI_SYSTEM     -11
    Right here.
    > +#define EAI_OVERFLOW   -12
    >   
    >   int getnameinfo(const struct sockaddr *addr, socklen_t addrlen,
    >                   char *host, socklen_t hostlen,
    > @@ -73,4 +81,5 @@ struct servent *getservbyname(const char *name, const 
char *proto);
    >   struct servent *getservbyport(int port, const char *proto);
    >   int getservbyport_r(int port, const char *prots, struct servent *se,
    >                       char *buf, size_t buflen, struct servent **res);
    > +#endif
    >   
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel