[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Minios-devel] [UNIKRAFT/PTHREAD-EMBEDDED PATCH 2/3] attributes.c: Allow GNU definitions regardless of _GNU_SOURCE
- To: "minios-devel@xxxxxxxxxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
- Date: Sun, 8 Dec 2019 22:36:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2rzfDGuLB8ZCrIFGSTl77nUs8Zz460wY/jUosFr4OQ=; b=PqiEVsFFmvA3nwYoitTk1I6PAQmebF/4Qxuy5qUTf++CB95Z+7oWbdtB4d/6Uf8lQgFm3FfGCAXMl+yxxD816ZESikxN2BxsdPU3z9suHSgQTO+UZYMn+guHuNFCpSfgah8l3XtN8jocc7ZOyC8eEZquYv4qrEkWF+BG9rxpQ8kI0fmgkOycaw6qtPtPV0KA+ojc5v9ijNkw8WsWFJrleEpuhusCRzEFEuvITTb7QImIuBCHz8G8z3+03l8b+13+sDQ+MmRbRUnzeTgF0DujZYEkPjButpuhcgi+jTgrA33JsNlGpx+xCrmRsXJC6e58NDkOdBr2TtkHauVTzuKQzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aPLvrWCH9sKW5LU46UHHEpsBQHWNwkI7HFP7a2UPd02dFZ3GuewoXIrcOfcbela80iJSMMlroazaObFCMGqolu8tgU17sWSWXPNMxvv+/iiUkXRjHd/EaiG5MeJeglOMvOro7EshG3hVd4V1h8jyZk8zIZKR1g1pe3+kbfUcxY/77+VVfKZCBh0w5RBM3hpPDaZnabmjHbp8hwtWHCVdz+pWfNccNY1QhBc2K4ykJ6mcE8jESbdPQYl/IA1TJPRkjRsB3Hqf94UlxbaJX2sLGTd2A8nJebsftPd5OVeB53KR5IDOhQvLsZQDHTzNySL23zNDzRNu2qkuVU2Wpei41A==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
- Delivery-date: Sun, 08 Dec 2019 22:36:38 +0000
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
- Thread-index: AQHVrDbjBrnRl+BJ20CKkzccPmqzvaew12+A
- Thread-topic: [Minios-devel] [UNIKRAFT/PTHREAD-EMBEDDED PATCH 2/3] attributes.c: Allow GNU definitions regardless of _GNU_SOURCE
Hi Costin,
I think that the commit message should specify that since this is the
gluecode of our ported library we are not constrained by portability and
such it's ok to not have guarded nonstandard GNU extensions.
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
On 06.12.2019 15:12, Costin Lupu wrote:
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
> attributes.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/attributes.c b/attributes.c
> index 7729096..a7b4842 100644
> --- a/attributes.c
> +++ b/attributes.c
> @@ -79,7 +79,6 @@ out:
> return rc;
> }
>
> -#ifdef _GNU_SOURCE
> int pthread_getattr_np(pthread_t thread, pthread_attr_t *attr)
> {
> pte_thread_t *tp = (pte_thread_t *) thread.p;
> @@ -150,5 +149,3 @@ int pthread_getname_np(pthread_t thread, char *name,
> size_t len)
>
> return 0;
> }
> -
> -#endif /* _GNU_SOURCE */
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
