Re: [Minios-devel] [UNIKRAFT/SQLITE V3 PATCH 5/5] Add config.h in include folder

[gaulthier.gain@xxxxxxxxx]

Hi Costin, 

Thanks for the review. I will consider your comments.

Gaulthier

----- Mail original -----
De: "Costin Lupu" <costin.lup@xxxxxxxxx>
À: "Gaulthier Gain" <gaulthier.gain@xxxxxxxxx>, 
minios-devel@xxxxxxxxxxxxxxxxxxxx
Cc: "felipe huici" <felipe.huici@xxxxxxxxx>
Envoyé: Jeudi 5 Décembre 2019 11:22:01
Objet: Re: [Minios-devel] [UNIKRAFT/SQLITE V3 PATCH 5/5] Add config.h in 
include folder

Hi Gaulthier,

For our previous ports, whenever we modified a generated file we used 2
patches for that file: first one introducing the file just as it was
generated (a simple copy-paste) and a second one either commenting or
removing what is not supported by Unikraft. It's easier this way to keep
track of the features that have to be enabled back, after we add those
missing features in Unikraft.

You can have a look for some examples at Python's [1] patches for
pyconfig.h and _sysconfigdata.py files or NGINX's [2] patches for
include/ngx_auto_config.h and ngx_modules.c files.

[1] https://github.com/unikraft/lib-python3/commits/staging
[2] https://github.com/unikraft/lib-nginx/commits/staging

Cheers,
Costin

On 12/4/19 7:52 PM, Gaulthier Gain wrote:
> This file contains SQLite configuration. Those are values/options
> generated by configure and are updated to support Unikraft.
> 
> Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
> ---
>  include/config.h | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 include/config.h
> 
> diff --git a/include/config.h b/include/config.h
> new file mode 100644
> index 0000000..98d81b3
> --- /dev/null
> +++ b/include/config.h
> @@ -0,0 +1,35 @@
> +/* Define to 1 if you have the `gmtime_r' function. */
> +#define HAVE_GMTIME_R 1
> +
> +/* Define to 1 if the system has the type `int16_t'. */
> +#define HAVE_INT16_T 1
> +
> +/* Define to 1 if the system has the type `int32_t'. */
> +#define HAVE_INT32_T 1
> +
> +/* Define to 1 if the system has the type `int64_t'. */
> +#define HAVE_INT64_T 1
> +
> +/* Define to 1 if the system has the type `int8_t'. */
> +#define HAVE_INT8_T 1
> +
> +/* Define to 1 if you have the <inttypes.h> header file. */
> +#define HAVE_INTTYPES_H 1
> +
> +/* Define to 1 if you have the `localtime_r' function. */
> +#define HAVE_LOCALTIME_R 1
> +
> +/* Define to 1 if the system has the type `uint16_t'. */
> +#define HAVE_UINT16_T 1
> +
> +/* Define to 1 if the system has the type `uint32_t'. */
> +#define HAVE_UINT32_T 1
> +
> +/* Define to 1 if the system has the type `uint64_t'. */
> +#define HAVE_UINT64_T 1
> +
> +/* Define to 1 if the system has the type `uint8_t'. */
> +#define HAVE_UINT8_T 1
> +
> +/* Define to 1 if you have the `usleep' function. */
> +#define HAVE_USLEEP 1
>

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel