Re: [Minios-devel] [LCMS PATCH 0/1]

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Esteban,

Thanks for this port. Here are my comments.

1) You should have used the "UNIKRAFT/LCMS PATCH" prefix. Your command
should have looked like this:

$ git format-patch --subject-prefix="UNIKRAFT/LCMS PATCH" -1 --cover-letter

But because we will need another version for this, you will use this
command (please notice the version number, v2, and 2 patches):

$ git format-patch --subject-prefix="UNIKRAFT/LCMS PATCH v2" -2
--cover-letter

2) Please don't leave the "BLURB HERE", say something there about the
series. And don't leave the subject blank. You have to manually edit the
cover patch.

Cheers,
Costin


On 12/2/19 1:45 PM, Esteban wrote:
> *** BLURB HERE ***
> 
> Esteban (1):
>   [LCMS PATCH] Add new library lcms 2.9 to Unikraft's project.
> 
>  CODING_STYLE.md |   4 ++
>  CONTRIBUTING.md |   4 ++
>  COPYING.md      |  41 +++++++++++++++
>  Config.uk       |  11 +++++
>  MAINTAINERS.md  |  11 +++++
>  Makefile.uk     | 129 ++++++++++++++++++++++++++++++++++++++++++++++++
>  README.md       |   7 +++
>  exportsyms.uk   |   1 +
>  8 files changed, 208 insertions(+)
>  create mode 100755 CODING_STYLE.md
>  create mode 100755 CONTRIBUTING.md
>  create mode 100755 COPYING.md
>  create mode 100755 Config.uk
>  create mode 100755 MAINTAINERS.md
>  create mode 100755 Makefile.uk
>  create mode 100755 README.md
>  create mode 100755 exportsyms.uk
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel