Re: [Minios-devel] [Xen-devel] [PATCH v2 6/6] Added Resolving Disagreement

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 28/11/2019, 12:50, "Stefano Stabellini" <sstabellini@xxxxxxxxxx> wrote:

    On Thu, 28 Nov 2019, Jan Beulich wrote:
    > On 28.11.2019 01:56, Stefano Stabellini wrote:
    > > On Thu, 26 Sep 2019, Lars Kurth wrote:

    > > I think a good recommendation would be for the contributor to try to
    > > follow the maintainers requests, even if they could be considered
    > > "style", trusting their experience on the matter. And a good
    > > recommendation for the maintainer would be to try to let the contributor
    > > have freedom of implementation choice on things that don't make a
    > > significant difference.
    > 
    > I think we try to, but I also think we suffer from too little
    > clear documentation on e.g. style aspects. Attempts on my part
    > to address this have mostly (not entirely) lead no-where (lack of
    > feedback on proposed patches to ./CODING_STYLE). So for the time
    > being there are (many) aspects where we have de-facto expectations
    > that aren't written down anywhere, with the result of (in a subset
    > of cases) disagreement on what the perceived de-facto standard
    > actually is.
    
    I recognize that it could be challenging finding a consensus to update
    CODING_STYLE but it might be worth doing to reduce frictions with both
    contributors and other reviewers.
    
    But to be clear, I was also referring to things that might be actually
    hard to add to CODING_STYLE, such as macro vs. static inlines, when to
    split a single function into multiple smaller functions, etc.
    
I think this is definitely something we ought to do. I am volunteering to
pick this up, but changing/clarifying the CODING_STYLE needs to be 
considered in conjunction with checking tools

I have parked this for now, as
a) I did not want to disrupt 4.13 
b) and until recently I also didn’t fully understand what kind of coding
standards would help with safety certification

And of course, having a bot do the checking would remove the friction
entirely. 

Lars


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel