[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/SQLITE PATCH V2 3/3] Add config.h in include folder



Hi Gaulthier, no, it's perfectly fine that you have a config.h file, I was just 
wondering why most of the options on there were off by default in your patch.

-- Felipe

On 25.11.19, 18:58, "Minios-devel on behalf of gaulthier.gain@xxxxxxxxx" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
gaulthier.gain@xxxxxxxxx> wrote:

    Hi Felipe, 
    
    Thanks for your comments.
    
    Concerning SQLite "config.h" file, we want to show all the available 
options to tweak SQLite.
    
    The idea is to let the developer/user set SQLite according to the 
"config.h" file.
    
    Maybe we can update this approach by showing these options in the README 
file? Or another approach?
    
    What do you think? 
    
    Gaulthier 
    
    ----- Mail original -----
    De: "Felipe Huici" <Felipe.Huici@xxxxxxxxx>
    À: "Gaulthier Gain" <gaulthier.gain@xxxxxxxxx>, minios-devel@xxxxxxxxxxxxx
    Envoyé: Jeudi 21 Novembre 2019 11:43:24
    Objet: Re: [Minios-devel] [UNIKRAFT/SQLITE PATCH V2 3/3] Add config.h in 
include folder
    
    Hi Gaulthier,
    
    You're disabling quite a few things that we do support, any reasoning 
behind this? 
    
    -- Felipe
    
    On 20.11.19, 15:21, "Minios-devel on behalf of Gaulthier Gain" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
gaulthier.gain@xxxxxxxxx> wrote:
    
        The file contains SQLite configuration and should be updated
        depending the underlying system.
        
        Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
        ---
         include/config.h | 132 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++
         1 file changed, 132 insertions(+)
         create mode 100644 include/config.h
        
        diff --git a/include/config.h b/include/config.h
        new file mode 100644
        index 0000000..bdbdbba
        --- /dev/null
        +++ b/include/config.h
        @@ -0,0 +1,132 @@
        +/* config.h.in.  Generated from configure.ac by autoheader.  */
        +
        +/* Define to 1 if you have the <dlfcn.h> header file. */
        +#undef HAVE_DLFCN_H
        +
        +/* Define to 1 if you have the `fdatasync' function. */
        +#undef HAVE_FDATASYNC
        +
        +/* Define to 1 if you have the `gmtime_r' function. */
        +#undef HAVE_GMTIME_R
        +
        +/* Define to 1 if the system has the type `int16_t'. */
        +#undef HAVE_INT16_T
        +
        +/* Define to 1 if the system has the type `int32_t'. */
        +#undef HAVE_INT32_T
        +
        +/* Define to 1 if the system has the type `int64_t'. */
        +#undef HAVE_INT64_T
        +
        +/* Define to 1 if the system has the type `int8_t'. */
        +#undef HAVE_INT8_T
        +
        +/* Define to 1 if the system has the type `intptr_t'. */
        +#undef HAVE_INTPTR_T
        +
        +/* Define to 1 if you have the <inttypes.h> header file. */
        +#undef HAVE_INTTYPES_H
        +
        +/* Define to 1 if you have the `isnan' function. */
        +#undef HAVE_ISNAN
        +
        +/* Define to 1 if you have the `localtime_r' function. */
        +#undef HAVE_LOCALTIME_R
        +
        +/* Define to 1 if you have the `localtime_s' function. */
        +#undef HAVE_LOCALTIME_S
        +
        +/* Define to 1 if you have the <malloc.h> header file. */
        +#undef HAVE_MALLOC_H
        +
        +/* Define to 1 if you have the `malloc_usable_size' function. */
        +#undef HAVE_MALLOC_USABLE_SIZE
        +
        +/* Define to 1 if you have the <memory.h> header file. */
        +#undef HAVE_MEMORY_H
        +
        +/* Define to 1 if you have the pread() function. */
        +#undef HAVE_PREAD
        +
        +/* Define to 1 if you have the pread64() function. */
        +#undef HAVE_PREAD64
        +
        +/* Define to 1 if you have the pwrite() function. */
        +#undef HAVE_PWRITE
        +
        +/* Define to 1 if you have the pwrite64() function. */
        +#undef HAVE_PWRITE64
        +
        +/* Define to 1 if you have the <stdint.h> header file. */
        +#undef HAVE_STDINT_H
        +
        +/* Define to 1 if you have the <stdlib.h> header file. */
        +#undef HAVE_STDLIB_H
        +
        +/* Define to 1 if you have the strchrnul() function */
        +#undef HAVE_STRCHRNUL
        +
        +/* Define to 1 if you have the <strings.h> header file. */
        +#undef HAVE_STRINGS_H
        +
        +/* Define to 1 if you have the <string.h> header file. */
        +#undef HAVE_STRING_H
        +
        +/* Define to 1 if you have the <sys/stat.h> header file. */
        +#undef HAVE_SYS_STAT_H
        +
        +/* Define to 1 if you have the <sys/types.h> header file. */
        +#undef HAVE_SYS_TYPES_H
        +
        +/* Define to 1 if the system has the type `uint16_t'. */
        +#undef HAVE_UINT16_T
        +
        +/* Define to 1 if the system has the type `uint32_t'. */
        +#undef HAVE_UINT32_T
        +
        +/* Define to 1 if the system has the type `uint64_t'. */
        +#undef HAVE_UINT64_T
        +
        +/* Define to 1 if the system has the type `uint8_t'. */
        +#undef HAVE_UINT8_T
        +
        +/* Define to 1 if the system has the type `uintptr_t'. */
        +#undef HAVE_UINTPTR_T
        +
        +/* Define to 1 if you have the <unistd.h> header file. */
        +#undef HAVE_UNISTD_H
        +
        +/* Define to 1 if you have the `usleep' function. */
        +#undef HAVE_USLEEP
        +
        +/* Define to 1 if you have the utime() library function. */
        +#undef HAVE_UTIME
        +
        +/* Define to the sub-directory in which libtool stores uninstalled
        + * libraries. */
        +#undef LT_OBJDIR
        +
        +/* Define to the address where bug reports for this package should be
        + * sent. */
        +#undef PACKAGE_BUGREPORT
        +
        +/* Define to the full name of this package. */
        +#undef PACKAGE_NAME
        +
        +/* Define to the full name and version of this package. */
        +#undef PACKAGE_STRING
        +
        +/* Define to the one symbol short name of this package. */
        +#undef PACKAGE_TARNAME
        +
        +/* Define to the version of this package. */
        +#undef PACKAGE_VERSION
        +
        +/* Define to 1 if you have the ANSI C header files. */
        +#undef STDC_HEADERS
        +
        +/* Number of bits in a file offset, on hosts where this is settable. */
        +#undef _FILE_OFFSET_BITS
        +
        +/* Define for large files, on AIX-style hosts. */
        +#undef _LARGE_FILES
        -- 
        2.11.0
        
        
        _______________________________________________
        Minios-devel mailing list
        Minios-devel@xxxxxxxxxxxxxxxxxxxx
        https://lists.xenproject.org/mailman/listinfo/minios-devel
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.