Re: [Minios-devel] [UNIKRAFT PATCH 1/3] lib/ukdebug: Move WARN_STUBBED to print.h

[Costin Lupu <costin.lup@xxxxxxxxx>]

Hi Mihai,

I'm going to move DO_ONCE() as well, but I can do it on upstreaming.

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 10/27/19 3:40 AM, Mihai Pogonaru wrote:
> Signed-off-by: Mihai Pogonaru <pogonarumihai@xxxxxxxxx>
> ---
>  lib/ukdebug/include/uk/print.h | 3 +++
>  lib/vfscore/main.c             | 1 -
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ukdebug/include/uk/print.h b/lib/ukdebug/include/uk/print.h
> index a107c199..6f4e9c41 100644
> --- a/lib/ukdebug/include/uk/print.h
> +++ b/lib/ukdebug/include/uk/print.h
> @@ -166,6 +166,9 @@ static inline void uk_printk(int lvl __unused, const char 
> *fmt __unused, ...)
>  #define uk_pr_err(fmt, ...)   uk_printk(KLVL_ERR,   (fmt), ##__VA_ARGS__)
>  #define uk_pr_crit(fmt, ...)  uk_printk(KLVL_CRIT,  (fmt), ##__VA_ARGS__)
>  
> +/* Warning for stubbed functions */
> +#define WARN_STUBBED() uk_pr_warn("%s() stubbed\n", __func__)
> +
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/lib/vfscore/main.c b/lib/vfscore/main.c
> index 39013767..5d81f207 100644
> --- a/lib/vfscore/main.c
> +++ b/lib/vfscore/main.c
> @@ -76,7 +76,6 @@ static mode_t global_umask = S_IWGRP | S_IWOTH;
>           thing ;                                     \
>       }                                               \
>  } while (0)
> -#define WARN_STUBBED() DO_ONCE(uk_pr_warn("%s() stubbed\n", __func__))
>  
>  static inline int libc_error(int err)
>  {
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel