Re: [Minios-devel] [UNIKRAFT/PYTHON3 PATCH] Enable bzip2 extension

[Costin Lupu <costin.lup@xxxxxxxxx>]

Thanks, Ștefan!

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 10/24/19 5:29 PM, Stefan Teodorescu wrote:
> Enable bzip2 library for Python 3. Unit test test_bz2 now passes
> successfuly.
> 
> Signed-off-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>
> ---
>  Config.uk        | 5 +++++
>  Makefile.uk      | 2 +-
>  modules_config.c | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Config.uk b/Config.uk
> index 095a063..1bdaef2 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -41,6 +41,11 @@ menuconfig LIBPYTHON3_EXTENSIONS
>       bool "Extensions"
>       default n
> 
> +if LIBBZIP2
> +config LIBPYTHON3_EXTENSION_BZIP2
> +     bool "bzip2"
> +     default y
> +endif
>  if LIBPYTHON3_EXTENSIONS
>  config LIBPYTHON3_EXTENSION_EXPAT
>       bool "Expat XML parser"
> diff --git a/Makefile.uk b/Makefile.uk
> index ed28f04..4640040 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -313,7 +313,7 @@ else
>  LIBPYTHON3_EXTENSIONS_SRCS-y += 
> $(LIBPYTHON3_SRC)/Modules/_blake2/impl/blake2b-ref.c
>  LIBPYTHON3_EXTENSIONS_SRCS-y += 
> $(LIBPYTHON3_SRC)/Modules/_blake2/impl/blake2s-ref.c
>  endif
> -#LIBPYTHON3_EXTENSIONS_SRCS-y += $(LIBPYTHON3_SRC)/Modules/_bz2module.c
> +LIBPYTHON3_EXTENSIONS_SRCS-y += $(LIBPYTHON3_SRC)/Modules/_bz2module.c
>  LIBPYTHON3_EXTENSIONS_SRCS-y += 
> $(LIBPYTHON3_SRC)/Modules/cjkcodecs/_codecs_cn.c
>  LIBPYTHON3_EXTENSIONS_SRCS-y += 
> $(LIBPYTHON3_SRC)/Modules/cjkcodecs/_codecs_hk.c
>  LIBPYTHON3_EXTENSIONS_SRCS-y += 
> $(LIBPYTHON3_SRC)/Modules/cjkcodecs/_codecs_iso2022.c
> diff --git a/modules_config.c b/modules_config.c
> index 9e408dc..e8f1c72 100644
> --- a/modules_config.c
> +++ b/modules_config.c
> @@ -215,7 +215,7 @@ struct _inittab _PyImport_Inittab[] = {
>      {"binascii", PyInit_binascii},
>      {"_bisect", PyInit__bisect},
>      {"_blake2", PyInit__blake2},
> -//    {"_bz2", PyInit__bz2},
> +    {"_bz2", PyInit__bz2},
>      {"cmath", PyInit_cmath},
>      {"_codecs", PyInit__codecs},
>      {"_collections", PyInit__collections},
> --
> 2.20.1
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel