Re: [Minios-devel] [UNIKRAFT PATCH v2 1/2] lib/nolibc: Guard sleep prototype with HAVE_TIME

[Santiago Pagani <Santiago.Pagani@xxxxxxxxx>]

Hi Costin,

Sure. I noticed you already upstreamed it. Are you also reviewing 2/2 or should 
I ask Justin to do that?

Thanks and best,
Santiago

On 22.10.19, 08:32, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    Hi Santiago,
    
    We can push this separately.
    
    Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    
    On 10/21/19 3:14 PM, Santiago Pagani wrote:
    > Guarded sleep() prototype in NOLIBC with HAVE_TIME,
    > as sleep() depends on HAVE_TIME and better to have
    > an undefined function than a linker error.
    > 
    > Signed-off-by: Santiago Pagani <santiago.pagani@xxxxxxxxx>
    > ---
    >  lib/nolibc/include/unistd.h | 2 ++
    >  1 file changed, 2 insertions(+)
    > 
    > diff --git a/lib/nolibc/include/unistd.h b/lib/nolibc/include/unistd.h
    > index a6986873..e6854e25 100644
    > --- a/lib/nolibc/include/unistd.h
    > +++ b/lib/nolibc/include/unistd.h
    > @@ -55,7 +55,9 @@ extern "C" {
    >  
    >  #include <nolibc-internal/shareddefs.h>
    >  
    > +#if CONFIG_HAVE_TIME
    >  unsigned int sleep(unsigned int seconds);
    > +#endif
    >  
    >  #if CONFIG_LIBVFSCORE
    >  int close(int fd);
    > 
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel