Re: [Minios-devel] [UNIKRAFT PATCH v4 4/7] plat/kvm/arm: Eliminate unused parameter warning of intctrl_ack_irq()

[Santiago Pagani <Santiago.Pagani@xxxxxxxxx>]

Hi Justin,

Thanks for the patch. It looks good.

Best,
Santiago

On 09.10.19, 15:30, "Jia He" <justin.he@xxxxxxx> wrote:

    Without this patch, compiler will report a warning:
    plat/kvm/arm/intctrl.c: In function 'intctrl_ack_irq':
    plat/kvm/arm/intctrl.c:52:35: warning: unused parameter 'irq' 
[-Wunused-parameter]
     void intctrl_ack_irq(unsigned int irq)
                                       ^~~
    Signed-off-by: Jia He <justin.he@xxxxxxx>
    ---
     plat/kvm/arm/intctrl.c | 3 ++-
     1 file changed, 2 insertions(+), 1 deletion(-)
    
    diff --git a/plat/kvm/arm/intctrl.c b/plat/kvm/arm/intctrl.c
    index dbd7f73..f625024 100644
    --- a/plat/kvm/arm/intctrl.c
    +++ b/plat/kvm/arm/intctrl.c
    @@ -37,6 +37,7 @@
     #include <arm/irq.h>
     #include <gic/gic-v2.h>
     #include <kvm/config.h>
    +#include <uk/essentials.h>
     
     void intctrl_init(void)
     {
    @@ -49,7 +50,7 @@ void intctrl_init(void)
     
     }
     
    -void intctrl_ack_irq(unsigned int irq)
    +void intctrl_ack_irq(unsigned int irq __unused)
     {
        //NOP
     }
    -- 
    2.17.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel