Re: [Minios-devel] [UNIKRAFT PATCH v2] plat/kvm: Automatically select Virtio PCI device for Virtio devices.

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Stefan,

The patch is fine. Thanks for the fix.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards

Sharan

On 10/17/19 5:51 PM, Stefan Teodorescu wrote:
> When selecting Virtio Net device or Virtio 9P, the PCI device wouldn't
> be automatically selected, even if it is a strong dependency.
>
> Signed-off-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>
> ---
>   plat/kvm/Config.uk | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/plat/kvm/Config.uk b/plat/kvm/Config.uk
> index 922cb1c..47ae8e2 100644
> --- a/plat/kvm/Config.uk
> +++ b/plat/kvm/Config.uk
> @@ -77,6 +77,7 @@ config VIRTIO_NET
>          default y if LIBUKNETDEV
>          default n
>          depends on LIBUKNETDEV
> +       imply VIRTIO_PCI if ARCH_X86_64
>          select VIRTIO_BUS
>          select LIBUKSGLIST
>          help
> @@ -87,6 +88,7 @@ config VIRTIO_9P
>          default y if LIBUK9P
>          default n
>          depends on LIBUK9P
> +       imply VIRTIO_PCI if ARCH_X86_64
>          select VIRTIO_BUS
>          select LIBUKSGLIST
>          help
> --
> 2.20.1
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel