Re: [Minios-devel] [UNIKRAFT PATCH] plat/kvm: Automatically select Virtio PCI device for Virtio devices.

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Stefan,

Please find the comment inline.

Thanks & Regards

Sharan

On 10/17/19 4:48 PM, Stefan Teodorescu wrote:
> When selecting Virtio Net device or Virtio 9P, the PCI device wouldn't
> be automatically selected, even if it is a strong dependency.
>
> Signed-off-by: Stefan Teodorescu <stefanl.teodorescu@xxxxxxxxx>
> ---
>   plat/kvm/Config.uk | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/plat/kvm/Config.uk b/plat/kvm/Config.uk
> index 922cb1c..20b9864 100644
> --- a/plat/kvm/Config.uk
> +++ b/plat/kvm/Config.uk
> @@ -78,6 +78,7 @@ config VIRTIO_NET
>          default n
>          depends on LIBUKNETDEV
>          select VIRTIO_BUS
> +       select VIRTIO_PCI
Instead of select we could use imply, which is weaker form of select. 
With the imply option, you can still deselect a particular 
configuration. Also VIRTIO_PCI should be enabled only on ARCH_X86_64.
>          select LIBUKSGLIST
>          help
>                 Virtual network driver.
> @@ -88,6 +89,7 @@ config VIRTIO_9P
>          default n
>          depends on LIBUK9P
>          select VIRTIO_BUS
> +       select VIRTIO_PCI
>          select LIBUKSGLIST
>          help
>                 Virtio 9P driver.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel