Re: [Minios-devel] [UNIKRAFT PATCH v2] lib/ukunistd: Rename to lib/posix-user

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin, this looks ok, thanks.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 17.10.19, 12:11, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    Since it was introduced, lib/ukunistd has provided only user-related
    functionality. Therefore it makes sense to rename it to posix-user and use 
it
    from now on just for this purpose. The 'posix-' prefix was chosen for 
showing
    that it merely provides POSIX compatibility.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     lib/Makefile.uk                                | 2 +-
     lib/posix-user/Config.uk                       | 3 +++
     lib/posix-user/Makefile.uk                     | 5 +++++
     lib/{ukunistd => posix-user}/exportsyms.uk     | 0
     lib/{ukunistd => posix-user}/include/uk/user.h | 0
     lib/{ukunistd => posix-user}/user.c            | 0
     lib/ukunistd/Config.uk                         | 3 ---
     lib/ukunistd/Makefile.uk                       | 5 -----
     8 files changed, 9 insertions(+), 9 deletions(-)
     create mode 100644 lib/posix-user/Config.uk
     create mode 100644 lib/posix-user/Makefile.uk
     rename lib/{ukunistd => posix-user}/exportsyms.uk (100%)
     rename lib/{ukunistd => posix-user}/include/uk/user.h (100%)
     rename lib/{ukunistd => posix-user}/user.c (100%)
     delete mode 100644 lib/ukunistd/Config.uk
     delete mode 100644 lib/ukunistd/Makefile.uk
    
    diff --git a/lib/Makefile.uk b/lib/Makefile.uk
    index 31248a1e..4b9568a1 100644
    --- a/lib/Makefile.uk
    +++ b/lib/Makefile.uk
    @@ -6,7 +6,7 @@
     
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukboot))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukswrand))
    -$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukunistd))
    +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/posix-user))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uksysinfo))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukdebug))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukargparse))
    diff --git a/lib/posix-user/Config.uk b/lib/posix-user/Config.uk
    new file mode 100644
    index 00000000..436ad1ea
    --- /dev/null
    +++ b/lib/posix-user/Config.uk
    @@ -0,0 +1,3 @@
    +config LIBPOSIX_USER
    +   bool "POSIX user-related functions"
    +   default n
    diff --git a/lib/posix-user/Makefile.uk b/lib/posix-user/Makefile.uk
    new file mode 100644
    index 00000000..6234e5f8
    --- /dev/null
    +++ b/lib/posix-user/Makefile.uk
    @@ -0,0 +1,5 @@
    +$(eval $(call addlib_s,libposix_user,$(CONFIG_LIBPOSIX_USER)))
    +
    +CINCLUDES-y   += -I$(LIBPOSIX_USER_BASE)/include
    +CXXINCLUDES-y += -I$(LIBPOSIX_USER_BASE)/include
    +LIBPOSIX_USER_SRCS-$(CONFIG_LIBPOSIX_USER) += $(LIBPOSIX_USER_BASE)/user.c
    diff --git a/lib/ukunistd/exportsyms.uk b/lib/posix-user/exportsyms.uk
    similarity index 100%
    rename from lib/ukunistd/exportsyms.uk
    rename to lib/posix-user/exportsyms.uk
    diff --git a/lib/ukunistd/include/uk/user.h 
b/lib/posix-user/include/uk/user.h
    similarity index 100%
    rename from lib/ukunistd/include/uk/user.h
    rename to lib/posix-user/include/uk/user.h
    diff --git a/lib/ukunistd/user.c b/lib/posix-user/user.c
    similarity index 100%
    rename from lib/ukunistd/user.c
    rename to lib/posix-user/user.c
    diff --git a/lib/ukunistd/Config.uk b/lib/ukunistd/Config.uk
    deleted file mode 100644
    index be0c94e1..00000000
    --- a/lib/ukunistd/Config.uk
    +++ /dev/null
    @@ -1,3 +0,0 @@
    -menuconfig UKUNISTD
    -   bool "ukunistd: POSIX operating system API"
    -   default n
    diff --git a/lib/ukunistd/Makefile.uk b/lib/ukunistd/Makefile.uk
    deleted file mode 100644
    index abdbbcd8..00000000
    --- a/lib/ukunistd/Makefile.uk
    +++ /dev/null
    @@ -1,5 +0,0 @@
    -$(eval $(call addlib_s,ukunistd,$(CONFIG_UKUNISTD)))
    -
    -CINCLUDES-y   += -I$(UKUNISTD_BASE)/include
    -CXXINCLUDES-y += -I$(UKUNISTD_BASE)/include
    -UKUNISTD_SRCS-$(CONFIG_UKUNISTD) += $(UKUNISTD_BASE)/user.c
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel