Re: [Minios-devel] [UNIKRAFT/LIBBENCHMARK PATCH v2 1/5] Introduce library skeleton

[Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>]

Hey Felipe,

Sure, I'll make the changes right away.

Thanks,

Vlad

On 15.10.2019 12:28, Felipe Huici wrote:
> Hi Vlad,
>
> Just a few minor comments, I think once these are fixed this will be ready 
> for upstreaming:
>
> * Add select LIBNEWLIBC to Config.uk
> * Add -Wno-deprecated-declarations to LIBBENCHMARK_SUPPRESS_FLAGS
> * Remove export keyword from src/sysinfo.cc 's getloadavg and sysctlbyname, 
> it's causing a warning too.
>
> Thanks,
>
> -- Felipe
>
> On 13.10.19, 15:41, "Vlad-Andrei BĂDOIU (78692)" 
> <vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:
>
>      We use the BSD-3-Clause license for this library glue code.
>      
>      Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
>      ---
>       .gitignore      | 27 +++++++++++++++++++++++++++
>       CODING_STYLE.md |  4 ++++
>       CONTRIBUTING.md |  4 ++++
>       COPYING.md      | 30 ++++++++++++++++++++++++++++++
>       Config.uk       | 10 ++++++++++
>       MAINTAINERS.md  | 11 +++++++++++
>       README.md       |  7 +++++++
>       7 files changed, 93 insertions(+)
>       create mode 100644 .gitignore
>       create mode 100644 CODING_STYLE.md
>       create mode 100644 CONTRIBUTING.md
>       create mode 100644 COPYING.md
>       create mode 100644 Config.uk
>       create mode 100644 MAINTAINERS.md
>       create mode 100644 README.md
>      
>      diff --git a/.gitignore b/.gitignore
>      new file mode 100644
>      index 0000000..75d2fd3
>      --- /dev/null
>      +++ b/.gitignore
>      @@ -0,0 +1,27 @@
>      +*.depend
>      +*.o
>      +*.a
>      +*.d
>      +*.so
>      +*.orig
>      +*.rej
>      +*.bak
>      +*.swp
>      +*~
>      +,*
>      +\#*\#
>      +.\#*
>      +\#_*\#
>      +.\#_*
>      +!.gitignore
>      +.*
>      +
>      +# gnu global files
>      +GPATH
>      +GRTAGS
>      +GSYMS
>      +GTAGS
>      +
>      +# cscope files
>      +cscope.*
>      +ncscope.*
>      diff --git a/CODING_STYLE.md b/CODING_STYLE.md
>      new file mode 100644
>      index 0000000..5730041
>      --- /dev/null
>      +++ b/CODING_STYLE.md
>      @@ -0,0 +1,4 @@
>      +Coding Style
>      +============
>      +
>      +Please refer to the `CODING_STYLE.md` file in the main Unikraft 
> repository.
>      diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
>      new file mode 100644
>      index 0000000..5f55eca
>      --- /dev/null
>      +++ b/CONTRIBUTING.md
>      @@ -0,0 +1,4 @@
>      +Contributing to Unikraft
>      +=======================
>      +
>      +Please refer to the `CONTRIBUTING.md` file in the main Unikraft 
> repository.
>      diff --git a/COPYING.md b/COPYING.md
>      new file mode 100644
>      index 0000000..9e844d7
>      --- /dev/null
>      +++ b/COPYING.md
>      @@ -0,0 +1,30 @@
>      +License
>      +=======
>      +
>      +Unikraft benchmark wrapper
>      +-----------------------
>      +
>      +This repository contains wrapper code to build benchmark with Unikraft.
>      +Each C code file in this repository should declare who is the
>      +copyright owner and under which terms and conditions the code is
>      +licensed. If such a licence note is missing, the following copyright
>      +notice will apply:
>      +
>      +        Copyright (c) 2019, University Politehnica of Bucharest. All 
> rights
>      +        reserved.
>      +
>      +        This library is free software; you can redistribute it and/or
>      +        modify it under the terms of the GNU Lesser General Public
>      +        License as published by the Free Software Foundation; either
>      +        version 2 of the License, or (at your option) any later version.
>      +        
>      +        This library is distributed in the hope that it will be useful,
>      +        but WITHOUT ANY WARRANTY; without even the implied warranty of
>      +        MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the 
> GNU
>      +        Lesser General Public License for more details.
>      +        
>      +        You should have received a copy of the GNU Lesser General Public
>      +        License along with this library in the file COPYING.LIB;
>      +        if not, write to the Free Software Foundation, Inc.,
>      +        59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
>      +
>      diff --git a/Config.uk b/Config.uk
>      new file mode 100644
>      index 0000000..73d439e
>      --- /dev/null
>      +++ b/Config.uk
>      @@ -0,0 +1,10 @@
>      +menuconfig LIBBENCHMARK
>      +        bool "Google Benchmark - A microbenchmark support library"
>      +        select LIBCXX
>      +        select LIBPTHREAD_EMBEDDED
>      +        select CXX_THREADS
>      +        select UKUNISTD
>      +        select UKSYSINFO
>      +        select LIBUKTIME
>      +        default n
>      +
>      diff --git a/MAINTAINERS.md b/MAINTAINERS.md
>      new file mode 100644
>      index 0000000..f8f998f
>      --- /dev/null
>      +++ b/MAINTAINERS.md
>      @@ -0,0 +1,11 @@
>      +Maintainers List
>      +================
>      +
>      +For notes on how to read this information, please refer to 
> `MAINTAINERS.md` in
>      +the main Unikraft repository.
>      +
>      +        LIBBENCHMARK-UNIKRAFT
>      +        M:      Felipe Huici <felipe.huici@xxxxxxxxx>
>      +        M:      Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
>      +        L:      minios-devel@xxxxxxxxxxxxx
>      +        F: *
>      diff --git a/README.md b/README.md
>      new file mode 100644
>      index 0000000..91a3844
>      --- /dev/null
>      +++ b/README.md
>      @@ -0,0 +1,7 @@
>      +benchmark for Unikraft
>      +===================
>      +
>      +This is the port of benchmark for Unikraft as external library.
>      +
>      +Please refer to the `README.md` as well as the documentation in the 
> `doc/`
>      +subdirectory of the main unikraft repository.
>      --
>      2.20.1
>      
>      
>
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel