Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukboot: Move liblwip_init to inittab

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 07.10.19 10:53, Sharan Santhanam wrote:
> We move the liblwip initialization to the into the lwip library
> and register it with the inittab.
>
> Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> ---
>   lib/ukboot/boot.c | 13 -------------
>   1 file changed, 13 deletions(-)
>
> diff --git a/lib/ukboot/boot.c b/lib/ukboot/boot.c
> index c115179..3f5046c 100644
> --- a/lib/ukboot/boot.c
> +++ b/lib/ukboot/boot.c
> @@ -63,9 +63,6 @@
>   #endif /* CONFIG_LIBUKLIBPARAM */
>   
>   int main(int argc, char *argv[]) __weak;
> -#ifdef CONFIG_LIBLWIP
> -extern int liblwip_init(void);
> -#endif /* CONFIG_LIBLWIP */
>   
>   static void main_thread_func(void *arg) __noreturn;
>   
> @@ -96,16 +93,6 @@ static void main_thread_func(void *arg)
>                 }
>         }
>   
> -#ifdef CONFIG_LIBLWIP
> -       /*
> -        * TODO: This is an initial implementation where we call the
> -        * initialization of lwip directly. We will remove this call
> -        * as soon as we introduced a more generic scheme for
> -        * (external) library initializations.
> -        */
> -       liblwip_init();
> -#endif /* CONFIG_LIBLWIP */
> -
>   #if CONFIG_LIBUKBOOT_BANNER
>         printf("Welcome to  _ __             _____\n");
>         printf(" __ _____  (_) /__ _______ _/ _/ /_\n");
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel