Re: [Minios-devel] [UNIKRAFT PATCH] lib/vfscore: Select uklibparam library when using root filesystem automounting

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Costin,

Please find the review comment inline:

Thanks & Regards

Sharan

On 10/9/19 3:30 PM, Costin Lupu wrote:
> Because you can provide the mount parameters using command line parameters.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   lib/vfscore/Config.uk | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/vfscore/Config.uk b/lib/vfscore/Config.uk
> index 527922da..2785a5d3 100644
> --- a/lib/vfscore/Config.uk
> +++ b/lib/vfscore/Config.uk
> @@ -17,6 +17,7 @@ config LIBVFSCORE_PIPE_SIZE_ORDER
>   config LIBVFSCORE_AUTOMOUNT_ROOTFS
>   bool "Automatically mount a root filesysytem (/)"
>   default n
> +select LIBUKLIBPARAM
Instead of hard selecting library, use "imply LIBUKLIBPARAM". This lets 
you unselect  LIBUKLIBPARAM.
The original intension was to build without LIBUKLIBPARAM and use 
suitable defaults. So it is wise to retain this behavior.
Thanks & Regards
Sharan

>   help
>         Automatically mounts '/' during boot. If `libuklibparam` is
>         compiled in, the default root filesystem and mount options can
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel