Re: [Minios-devel] [UNIKRAFT PATCH v5 3/7] plat/common: Record boot_ticks at very beginning

[Santiago Pagani <Santiago.Pagani@xxxxxxxxx>]

This patch looks good. Thanks!

On 25.09.19, 11:14, "Jia He" <justin.he@xxxxxxx> wrote:

    The position of recording boot_ticks is a little later. We moved
    it to the very beginning of platform call timer initialization
    function.
    
    Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
    Signed-off-by: Jianyong Wu <jianyong.wu@xxxxxxx>
    Signed-off-by: Jia He <justin.he@xxxxxxx>
    ---
     plat/common/arm/time.c | 11 ++++++-----
     1 file changed, 6 insertions(+), 5 deletions(-)
    
    diff --git a/plat/common/arm/time.c b/plat/common/arm/time.c
    index 8127454..98b3764 100644
    --- a/plat/common/arm/time.c
    +++ b/plat/common/arm/time.c
    @@ -236,11 +236,6 @@ static int generic_timer_init(void)
        UK_BUGON(!tick_per_ns);
     
        max_convert_ticks = __MAX_CONVERT_SECS*counter_freq;
    -   /*
    -    * Monotonic time begins at boot_ticks (first read of counter
    -    * before calibration).
    -    */
    -   boot_ticks = generic_timer_get_ticks();
     
        return 0;
     }
    @@ -283,6 +278,12 @@ void ukplat_time_init(void)
     {
        int rc;
     
    +   /*
    +    * Monotonic time begins at boot_ticks (first read of counter
    +    * before calibration).
    +    */
    +   boot_ticks = generic_timer_get_ticks();
    +
        rc = ukplat_irq_register(0, timer_handler, NULL);
        if (rc < 0)
                UK_CRASH("Failed to register timer interrupt handler\n");
    -- 
    2.17.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel