Re: [Minios-devel] [UNIKRAFT PATCH 0/3] Time functions refactoring

[Roxana Nicolescu <nicolescu.roxana1996@xxxxxxxxx>]

Hi Costin,

Thanks for the patches.

I tried to test the changes, but the `uktime` library didn't compile with `nolibc`.

It seems to be a problem with having two headers with the same name: `time.h` in both `nolibs` and `uktime/musl-imported`.

Some files in `musl-imported` don't recognize a structure because of this.

Roxana

On Thu, Oct 3, 2019 at 1:40 PM Costin Lupu <costin.lupu@xxxxxxxxx> wrote:

nolibc and newlib have duplicated code for time functions, therefore it makes
more sense to move them in common library.

Costin Lupu (3):
  lib/nolibc: Move time.c to lib/uktime
  lib/uktime: Add the missing changes from newlib's time.c
  lib/uktime: Fix 'no new line at end of file' warning in Config.uk

 lib/nolibc/Makefile.uk        |  1 -
 lib/uktime/Config.uk          |  2 +-
 lib/uktime/Makefile.uk        |  1 +
 lib/{nolibc => uktime}/time.c | 39 ++++++++++++++++++++++++++++++++---
 4 files changed, 38 insertions(+), 5 deletions(-)
 rename lib/{nolibc => uktime}/time.c (84%)

--
2.20.1

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel