|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Minios-devel] [UNIKRAFT/LIBWAMR PATCH 1/3] Introduce library skeleton
Hi Justin,
Thanks for the review, please see inline.
-- Felipe
On 17.09.19, 17:00, "Minios-devel on behalf of Jia He"
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of jiakernel2@xxxxxxxxx>
wrote:
Hi Felipe
Please see the inline below
On 2019/8/29 7:03, Felipe Huici wrote:
> We use the BSD-3-Clause license for this library glue code.
>
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
> .gitignore | 27 +++++++++++++++++++++++++++
> CODING_STYLE.md | 4 ++++
> CONTRIBUTING.md | 4 ++++
> COPYING.md | 39 +++++++++++++++++++++++++++++++++++++++
> Config.uk | 4 ++++
> MAINTAINERS.md | 10 ++++++++++
> README.md | 9 +++++++++
> exportsyms.uk | 1 +
> 8 files changed, 98 insertions(+)
> create mode 100644 .gitignore
> create mode 100644 CODING_STYLE.md
> create mode 100644 CONTRIBUTING.md
> create mode 100644 COPYING.md
> create mode 100644 Config.uk
> create mode 100644 MAINTAINERS.md
> create mode 100644 README.md
> create mode 100644 exportsyms.uk
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..57ef821
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,27 @@
> +.depend
> +*.o
> +*.a
> +*.d
> +*.so
> +*.orig
> +*.rej
> +*.bak
> +*.swp
> +*~
> +,*
> +\#*\#
> +.\#*
> +\#_*\#
> +.\#_*
> +!.gitignore
> +.*
> +
> +# gnu global files
> +GPATH
> +GRTAGS
> +GSYMS
> +GTAGS
> +
> +# cscope files
> +cscope.*
> +ncscope.*
> diff --git a/CODING_STYLE.md b/CODING_STYLE.md
> new file mode 100644
> index 0000000..5730041
> --- /dev/null
> +++ b/CODING_STYLE.md
> @@ -0,0 +1,4 @@
> +Coding Style
> +============
> +
> +Please refer to the `CODING_STYLE.md` file in the main Unikraft
repository.
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> new file mode 100644
> index 0000000..14f6ac6
> --- /dev/null
> +++ b/CONTRIBUTING.md
> @@ -0,0 +1,4 @@
> +Contributing to Unikraft
> +========================
> +
> +Please refer to the `CONTRIBUTING.md` file in the main Unikraft
repository.
> diff --git a/COPYING.md b/COPYING.md
> new file mode 100644
> index 0000000..a828207
> --- /dev/null
> +++ b/COPYING.md
> @@ -0,0 +1,39 @@
> +License
> +=======
> +
> +Unikraft wamr wrappers
> +----------------------------------
> +
> +This repository contains wrapper code to build wamr with Unikraft.
> +Each C code file in this repository should declare who is the
> +copyright owner and under which terms and conditions the code is
> +licensed. If such a licence note is missing, the following copyright
> +notice will apply:
> +
> + Copyright (c) Year, Institution. All rights reserved.
> +
> + Redistribution and use in source and binary forms, with or without
> + modification, are permitted provided that the following conditions
> + are met:
> +
> + 1. Redistributions of source code must retain the above copyright
> + notice, this list of conditions and the following disclaimer.
> + 2. Redistributions in binary form must reproduce the above copyright
> + notice, this list of conditions and the following disclaimer in the
> + documentation and/or other materials provided with the distribution.
> + 3. Neither the name of the copyright holder nor the names of its
> + contributors may be used to endorse or promote products derived from
> + this software without specific prior written permission.
> +
> + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS"
> + AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
THE
> + IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE
> + ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
BE
> + LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
THE
> + POSSIBILITY OF SUCH DAMAGE.
> +
> diff --git a/Config.uk b/Config.uk
> new file mode 100644
> index 0000000..92eeecb
> --- /dev/null
> +++ b/Config.uk
> @@ -0,0 +1,4 @@
> +menuconfig LIBWAMR
> + bool "wamr - Intel's WebAssembly Micro Runtime"
> + default y
> + select HAVE_LIBC
As we talked before, maybe you need to make it explicitly depend on
lwip and pthread-embedded.
Ok, will fix in the next version.
> diff --git a/MAINTAINERS.md b/MAINTAINERS.md
> new file mode 100644
> index 0000000..4059425
> --- /dev/null
> +++ b/MAINTAINERS.md
> @@ -0,0 +1,10 @@
> +Maintainers List
> +================
> +
> +For notes on how to read this information, please refer to
`MAINTAINERS.md` in
> +the main Unikraft repository.
> +
> + LIBPCRE-UNIKRAFT
> + M: Felipe Huici <felipe.huici@xxxxxxxxx>
> + L: minios-devel@xxxxxxxxxxxxx
> + F: *
> diff --git a/README.md b/README.md
> new file mode 100644
> index 0000000..0527ae7
> --- /dev/null
> +++ b/README.md
> @@ -0,0 +1,9 @@
> +wamr for Unikraft
> +=============================
> +
> +This is the port of warm for Unikraft as external library. If given
s/warm/wamr
Will fix.
> +the --repl parameter this port will run REPL mode. Alternatively you
> +can run a program from a file if passed as a initrd parameter.
> +
> +Please refer to the `README.md` as well as the documentation in the
`doc/`
> +subdirectory of the main unikraft repository.
> diff --git a/exportsyms.uk b/exportsyms.uk
> new file mode 100644
> index 0000000..c86c3f3
> --- /dev/null
> +++ b/exportsyms.uk
> @@ -0,0 +1 @@
> +none
> \ No newline at end of file
--
---
Cheers,
Justin (Jia He)
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |