Re: [Minios-devel] [UNIKRAFT/LIBAXTLS PATCH v2 1/3] Introduce library skeleton

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Felipe,

This patch seems fine. There is a checkpatch error with a space. We can 
fix it while upstreaming the patch.
Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards

Sharan

On 9/17/19 11:38 AM, Felipe Huici wrote:
> We use the BSD-3-Clause license for this library glue code.
>
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
>   .gitignore      | 27 +++++++++++++++++++++++++++
>   CODING_STYLE.md |  4 ++++
>   CONTRIBUTING.md |  4 ++++
>   COPYING.md      | 38 ++++++++++++++++++++++++++++++++++++++
>   Config.uk       |  5 +++++
>   MAINTAINERS.md  | 10 ++++++++++
>   README.md       | 16 ++++++++++++++++
>   7 files changed, 104 insertions(+)
>   create mode 100644 .gitignore
>   create mode 100644 CODING_STYLE.md
>   create mode 100644 CONTRIBUTING.md
>   create mode 100644 COPYING.md
>   create mode 100644 Config.uk
>   create mode 100644 MAINTAINERS.md
>   create mode 100644 README.md
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..75d2fd3
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,27 @@
> +*.depend
> +*.o
> +*.a
> +*.d
> +*.so
> +*.orig
> +*.rej
> +*.bak
> +*.swp
> +*~
> +,*
> +\#*\#
> +.\#*
> +\#_*\#
> +.\#_*
> +!.gitignore
> +.*
> +
> +# gnu global files
> +GPATH
> +GRTAGS
> +GSYMS
> +GTAGS
> +
> +# cscope files
> +cscope.*
> +ncscope.*
> diff --git a/CODING_STYLE.md b/CODING_STYLE.md
> new file mode 100644
> index 0000000..5730041
> --- /dev/null
> +++ b/CODING_STYLE.md
> @@ -0,0 +1,4 @@
> +Coding Style
> +============
> +
> +Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> new file mode 100644
> index 0000000..5f55eca
> --- /dev/null
> +++ b/CONTRIBUTING.md
> @@ -0,0 +1,4 @@
> +Contributing to Unikraft
> +=======================
> +
> +Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
> diff --git a/COPYING.md b/COPYING.md
> new file mode 100644
> index 0000000..24cf7c1
> --- /dev/null
> +++ b/COPYING.md
> @@ -0,0 +1,38 @@
> +License
> +=======
> +
> +Unikraft axtls wrappers
> +------------------------
> +
> +This repository contains wrapper code to build libuuid with Unikraft.
> +Each C code file in this repository should declare who is the
> +copyright owner and under which terms and conditions the code is
> +licensed. If such a licence note is missing, the following copyright
> +notice will apply:
> +
> +       Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights 
> reserved.
> +
> +       Redistribution and use in source and binary forms, with or without
> +       modification, are permitted provided that the following conditions
> +       are met:
> +
> +       1. Redistributions of source code must retain the above copyright
> +          notice, this list of conditions and the following disclaimer.
> +       2. Redistributions in binary form must reproduce the above copyright
> +          notice, this list of conditions and the following disclaimer in the
> +          documentation and/or other materials provided with the distribution.
> +       3. Neither the name of the copyright holder nor the names of its
> +          contributors may be used to endorse or promote products derived from
> +          this software without specific prior written permission.
> +
> +       THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> IS"
> +       AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
> THE
> +       IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
> PURPOSE
> +       ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
> BE
> +       LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> +       CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> +       SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> +       INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> +       CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +       ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
> THE
> +       POSSIBILITY OF SUCH DAMAGE.
> diff --git a/Config.uk b/Config.uk
> new file mode 100644
> index 0000000..084b6ea
> --- /dev/null
> +++ b/Config.uk
> @@ -0,0 +1,5 @@
> +config LIBAXTLS
> +          bool "axTLS - Embedded SSL"
> +          default n
> +          select LIBNEWLIBC
> +          select LIBLWIP
> diff --git a/MAINTAINERS.md b/MAINTAINERS.md
> new file mode 100644
> index 0000000..6a2f0e2
> --- /dev/null
> +++ b/MAINTAINERS.md
> @@ -0,0 +1,10 @@
> +Maintainers List
> +================
> +
> +For notes on how to read this information, please refer to `MAINTAINERS.md` in
> +the main Unikraft repository.
> +
> +       AXTLS-UNIKRAFT
> +       M:      Felipe Huici <felipe.huici@xxxxxxxxx>
> +       L:      minios-devel@xxxxxxxxxxxxx
> +       F: *
> diff --git a/README.md b/README.md
> new file mode 100644
> index 0000000..d12786c
> --- /dev/null
> +++ b/README.md
> @@ -0,0 +1,16 @@
> +axtls for Unikraft
> +===================
> +This is the port of axtls for Unikraft as external library. You will
> +need lwip to make it work.
> +
> +To run ssltest.c as a unit test, you'll need pthread support, e.g.,
> +add the following line to the LIBS variable in the Makefile:
> +
> +   ...$(UK_LIBS)/lwip:$(UK_LIBS)/pthread-embedded:
> +      $(UK_LIBS)/newlib:$(UK_LIBS)/axtls...
> +
> +Note that you'll need a filesystem in place and the certificate files for
> +all tests to pass.
> +
> +Please refer to the `README.md` as well as the documentation in the `doc/`
> +subdirectory of the main unikraft repository.
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel