Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH v2] Remove mmap from newlib glue code and create a new internal library (libukmmap) for mmap

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Charalampos,

This patch looks good, I'll clean up the commit message on upstream ("please 
ignore...", "please review..." are internal notes and don't belong in the 
commit message).

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 19.09.19, 11:33, "Minios-devel on behalf of Charalampos Mainas" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Charalampos.Mainas@xxxxxxxxx> wrote:

    Please ignore first version. Changes since last version:
     - Add PATCH in subject line 
    
    Please review this patch with lib/ukmmap patch series.
    
    Signed-off-by: Charalampos Mainas <Charalampos.Mainas@xxxxxxxxx>
    ---
     file.c | 12 ------------
     1 file changed, 12 deletions(-)
    
    diff --git a/file.c b/file.c
    index 006f191..da44e37 100644
    --- a/file.c
    +++ b/file.c
    @@ -54,18 +54,6 @@ extern int errno;
     #define STDOUT_FILENO   1       /* standard output file descriptor */
     #define STDERR_FILENO   2       /* standard error file descriptor */
     
    -#include <sys/mman.h>
    -void *mmap(void *addr __unused, size_t len __unused, int prot __unused,
    -           int flags __unused, int fildes __unused, off_t off __unused)
    -{
    -   return 0;
    -}
    -
    -int munmap(void *addr __unused, size_t len __unused)
    -{
    -   return 0;
    -}
    -
     #if !CONFIG_LWIP_SOCKET
     int poll(struct pollfd _pfd[] __unused, nfds_t _nfds __unused,
                int _timeout __unused)
    -- 
    2.17.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel