Re: [Minios-devel] [UNIKRAFT PATCH v4 2/4] sys/mman.h: Adapt to unikraft

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Charalampos,

This patch looks good, I'll remove the TODOs on upstreaming since nolibc will 
never support musl-internal headers.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>


On 20.09.19, 17:45, "Minios-devel on behalf of Charalampos Mainas" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Charalampos.Mainas@xxxxxxxxx> wrote:

    Signed-off-by: Charalampos Mainas <Charalampos.Mainas@xxxxxxxxx>
    ---
     lib/nolibc/musl-imported/include/sys/mman.h | 7 ++++---
     1 file changed, 4 insertions(+), 3 deletions(-)
    
    diff --git a/lib/nolibc/musl-imported/include/sys/mman.h 
b/lib/nolibc/musl-imported/include/sys/mman.h
    index d0761b18..8a428403 100644
    --- a/lib/nolibc/musl-imported/include/sys/mman.h
    +++ b/lib/nolibc/musl-imported/include/sys/mman.h
    @@ -4,7 +4,7 @@
     extern "C" {
     #endif
     
    -#include <features.h>
    +/* TODO: #include <features.h> */
     
     #define __NEED_mode_t
     #define __NEED_size_t
    @@ -14,7 +14,8 @@ extern "C" {
     #define __NEED_ssize_t
     #endif
     
    -#include <bits/alltypes.h>
    +#include <nolibc-internal/shareddefs.h>
    +/* TODO: #include <bits/alltypes.h> */
     
     #define MAP_FAILED ((void *) -1)
     
    @@ -107,7 +108,7 @@ extern "C" {
     #define MFD_HUGETLB 0x0004U
     #endif
     
    -#include <bits/mman.h>
    +/* TODO: #include <bits/mman.h> */
     
     void *mmap (void *, size_t, int, int, int, off_t);
     int munmap (void *, size_t);
    -- 
    2.17.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel