Re: [Minios-devel] [UNIKRAFT PATCH v3 17/23] lib: Use glob instead of adding each lib

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

This patch looks ok.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 19.09.19, 11:17, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Sharan.Santhanam@xxxxxxxxx> wrote:

    Since the kconfig version supports wild card operations
    we replace addition of the individual library with a wild
    card operation on the 'lib/' directory.
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     lib/Config.uk | 28 +---------------------------
     1 file changed, 1 insertion(+), 27 deletions(-)
    
    diff --git a/lib/Config.uk b/lib/Config.uk
    index f0d6205..23e705d 100644
    --- a/lib/Config.uk
    +++ b/lib/Config.uk
    @@ -27,30 +27,4 @@ config HAVE_NW_STACK
     # Library definitions
     #
     
################################################################################
    -source "lib/ukboot/Config.uk"
    -source "lib/ukdebug/Config.uk"
    -source "lib/ukargparse/Config.uk"
    -source "lib/ukunistd/Config.uk"
    -source "lib/uksysinfo/Config.uk"
    -source "lib/uktimeconv/Config.uk"
    -source "lib/nolibc/Config.uk"
    -source "lib/ukalloc/Config.uk"
    -source "lib/ukallocbbuddy/Config.uk"
    -source "lib/uksched/Config.uk"
    -source "lib/ukschedcoop/Config.uk"
    -source "lib/fdt/Config.uk"
    -source "lib/syscall_shim/Config.uk"
    -source "lib/vfscore/Config.uk"
    -source "lib/ramfs/Config.uk"
    -source "lib/devfs/Config.uk"
    -source "lib/9pfs/Config.uk"
    -source "lib/uklock/Config.uk"
    -source "lib/ukmpi/Config.uk"
    -source "lib/ukswrand/Config.uk"
    -source "lib/ukbus/Config.uk"
    -source "lib/uksglist/Config.uk"
    -source "lib/uknetdev/Config.uk"
    -source "lib/uk9p/Config.uk"
    -source "lib/posix-libdl/Config.uk"
    -source "lib/uklibparam/Config.uk"
    -source "lib/uktime/Config.uk"
    +source "lib/*/Config.uk"
    -- 
    2.7.4
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel