Re: [Minios-devel] [UNIKRAFT PATCH v3 06/23] kconfig: Removing the generic rule

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

This patch looks ok.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 19.09.19, 11:16, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Sharan.Santhanam@xxxxxxxxx> wrote:

    The generic rule to build c and cc are no longer needed to build the
    kconfig tools. It uses fixdep to determine if the config tool has to be
    built and execute the build command as necessary.
    
    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     support/kconfig.new/Makefile.br                    | 12 ----------
     support/kconfig.new/patches/04-remove-generic-rule | 26 
++++++++++++++++++++++
     2 files changed, 26 insertions(+), 12 deletions(-)
     create mode 100644 support/kconfig.new/patches/04-remove-generic-rule
    
    diff --git a/support/kconfig.new/Makefile.br 
b/support/kconfig.new/Makefile.br
    index 0fdbe9a..c11f297 100644
    --- a/support/kconfig.new/Makefile.br
    +++ b/support/kconfig.new/Makefile.br
    @@ -31,18 +31,6 @@ $(host-cmulti): %: $(host-cobjs) $(host-cshlib)
     $(host-cxxmulti): %: $(host-cxxobjs) $(host-cobjs) $(host-cshlib)
        $(HOSTCXX) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCXXFLAGS_$@) 
$(addprefix $(obj)/,$($(@F)-objs) $($(@F)-cxxobjs)) $(HOSTLOADLIBES_$(@F)) -o 
$(obj)/$@
     
    -$(obj)/%.o: %.c
    -   $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) -c $< 
-o $@
    -
    -$(obj)/%.o: $(obj)/%.c
    -   $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) -c $< 
-o $@
    -
    -$(obj)/%.o: %.cc
    -   $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCXXFLAGS_$(@F)) -c $< 
-o $@
    -
    -$(obj)/%:: $(src)/%_shipped
    -   $(Q)cat $< > $@
    -
     clean:
        $(Q)rm -f $(addprefix $(obj)/,$(clean-files))
     distclean: clean
    diff --git a/support/kconfig.new/patches/04-remove-generic-rule 
b/support/kconfig.new/patches/04-remove-generic-rule
    new file mode 100644
    index 0000000..3de0cb1
    --- /dev/null
    +++ b/support/kconfig.new/patches/04-remove-generic-rule
    @@ -0,0 +1,26 @@
    +diff --git a/support/kconfig.new/Makefile.br 
b/support/kconfig.new/Makefile.br
    +index 0fdbe9a..c11f297 100644
    +--- a/support/kconfig.new/Makefile.br
    ++++ b/support/kconfig.new/Makefile.br
    +@@ -31,18 +31,6 @@ $(host-cmulti): %: $(host-cobjs) $(host-cshlib)
    + $(host-cxxmulti): %: $(host-cxxobjs) $(host-cobjs) $(host-cshlib)
    +   $(HOSTCXX) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCXXFLAGS_$@) 
$(addprefix $(obj)/,$($(@F)-objs) $($(@F)-cxxobjs)) $(HOSTLOADLIBES_$(@F)) -o 
$(obj)/$@
    + 
    +-$(obj)/%.o: %.c
    +-  $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) -c $< 
-o $@
    +-
    +-$(obj)/%.o: $(obj)/%.c
    +-  $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCFLAGS_$(@F)) -c $< 
-o $@
    +-
    +-$(obj)/%.o: %.cc
    +-  $(HOSTCC) $(HOST_EXTRACFLAGS) $(HOSTCFLAGS) $(HOSTCXXFLAGS_$(@F)) -c $< 
-o $@
    +-
    +-$(obj)/%:: $(src)/%_shipped
    +-  $(Q)cat $< > $@
    +-
    + clean:
    +   $(Q)rm -f $(addprefix $(obj)/,$(clean-files))
    + distclean: clean
    +diff --git a/support/kconfig.new/patches/04-remove-generic-rule 
b/support/kconfig.new/patches/04-remove-generic-rule
    +new file mode 100644
    +index 0000000..e69de29
    -- 
    2.7.4
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel