Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Configure IO C99 formats and errno extensions

[Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>]

Hi Costin,

This patch looks good. Thanks!

Vlad

Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>

On 12.09.2019 11:36, Costin Lupu wrote:
> This patch adds support for enabling the following extensions:
> * IO C99 formats enable more options for formatting output. We need this to
> support "%z" in Python 3
> * Linux errno extensions define more error numbers. We need this to support
> ESHUTDOWN in Python 3
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   Config.uk   | 10 ++++++++++
>   Makefile.uk |  2 ++
>   2 files changed, 12 insertions(+)
>
> diff --git a/Config.uk b/Config.uk
> index 89010a1..da587ba 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -10,3 +10,13 @@ menuconfig LIBNEWLIBC
>       select LIBNEWLIBM if LIBNEWLIBC
>       select LIBUKALLOC
>       select LIBVFSCORE
> +
> +if LIBNEWLIBC
> +     config LIBNEWLIBC_WANT_IO_C99_FORMATS
> +             bool "Use C99 IO formats"
> +             default n
> +
> +     config LIBNEWLIBC_LINUX_ERRNO_EXTENSIONS
> +             bool "Use Linux errno extensions"
> +             default n
> +endif
> diff --git a/Makefile.uk b/Makefile.uk
> index 01da724..812f602 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -82,6 +82,8 @@ LIBNEWLIBM_CXXINCLUDES += -I$(LIBNEWLIB_LIBM)/common
>   
> ################################################################################
>   LIBNEWLIB_GLOBAL_FLAGS-y  += -DMISSING_SYSCALL_NAMES -DMALLOC_PROVIDED
>   LIBNEWLIB_GLOBAL_FLAGS-y  += -D_POSIX_REALTIME_SIGNALS
> +LIBNEWLIB_GLOBAL_FLAGS-$(CONFIG_LIBNEWLIBC_WANT_IO_C99_FORMATS) += 
> -D_WANT_IO_C99_FORMATS
> +LIBNEWLIB_GLOBAL_FLAGS-$(CONFIG_LIBNEWLIBC_LINUX_ERRNO_EXTENSIONS) += 
> -D__LINUX_ERRNO_EXTENSIONS__
>   
>   CFLAGS-y   += $(LIBNEWLIB_GLOBAL_FLAGS-y)
>   CXXFLAGS-y += $(LIBNEWLIB_GLOBAL_FLAGS-y)
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel