Re: [Minios-devel] [UNIKRAFT PATCH v2 1/6] lib/ukboot: Application constructors right before calling application

[Costin Lupu <costin.lup@xxxxxxxxx>]

On 9/13/19 8:10 PM, Simon Kuenzer wrote:
> On 08.09.19 17:02, Costin Lupu wrote:
>> Hi Simon,
>>
>> If we keep moving this code up and down, wouldn't it make more sense to
>> put it in a function instead?
> 
> You mean a static function? Because of readability? I am not sure if in
> this case this makes such a difference. You would need to do this then
> also with the system constructor table. However, I am concerned that
> this would bloat my patch which supposedly should make only the order
> correct.

Maybe I'm wrong, but I remember that this snippet of code was moved
before from other place which would mean that this might not be its
final position. But if we put it in a function then the next time we'll
move only the function call. This is what I wanted to suggest.

Cheers,
Costin

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel