Re: [Minios-devel] [UNIKRAFT PATCH] lib/vfscore: sys_ioctl() - Fix build with nolibc

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Costin,

The fix seems fine. Please find the question inline.

Thanks & Regards

Sharan

On 9/11/19 1:56 PM, Costin Lupu wrote:
> Commit 3dcccd04 introduced handling of FIOCLEX and FIONCLEX requests. However,
> these flags are not defined in nolibc.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>   lib/nolibc/include/sys/ioctl.h | 0
Why do we introduce a empty file? In newlib we introduces a header 
imported from musl.
Why don't we use the same file here?

>   lib/vfscore/syscalls.c         | 4 ++++
>   2 files changed, 4 insertions(+)
>   create mode 100644 lib/nolibc/include/sys/ioctl.h
>
> diff --git a/lib/nolibc/include/sys/ioctl.h b/lib/nolibc/include/sys/ioctl.h
> new file mode 100644
> index 00000000..e69de29b
> diff --git a/lib/vfscore/syscalls.c b/lib/vfscore/syscalls.c
> index d375774a..e85c4eb5 100644
> --- a/lib/vfscore/syscalls.c
> +++ b/lib/vfscore/syscalls.c
> @@ -390,12 +390,16 @@ sys_ioctl(struct vfscore_file *fp, unsigned long request, 
> void *buf)
>                 return EBADF;
>   
>   	switch (request) {
> +#ifdef FIOCLEX
>         case FIOCLEX:
>                 fp->f_flags |= O_CLOEXEC;
>                 break;
> +#endif
> +#ifdef FIONCLEX
>         case FIONCLEX:
>                 fp->f_flags &= ~O_CLOEXEC;
>                 break;
> +#endif
>         default:
>                 error = vfs_ioctl(fp, request, buf);
>                 break;
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel