[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Minios-devel] [UNIKRAFT/LWIP PATCH 5/5] Makefile.uk: Suppress 'unused parameters' warnings
- To: Costin Lupu <costin.lupu@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
- From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
- Date: Mon, 9 Sep 2019 14:21:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lz9UKSsvrtyqwjtmktYJziphDgFqFNxruvtDSZNA6GU=; b=i71rYPwIB5tZVuyqNXjYXtuET9mTfxfMY41jNpeJ0h5DTSxdLR7HZ+rK+eKiDU541PsOlvA4fd6jDoypfYA/TkWtDYHrapnIZe4PIBm6fzfme6K4SThthUk+pngO5nqFts3kXTHk8gvjIjdVixij+fg4watlAuoTm/xb4/sPftDDQg2w4J/LXEAmpz2YO0ZitnWi5queUuZI582vBR8xVEwUcEPHrQ6AbC3EOJT6NGdxAXHGzCnlNPohuCP9pjhBxMyn5nq1EnYdJIQW10u5N4QuwrBbvw2aYN0TsekqTlYJPW42wVHeRjHOq0JM/I7HtbiQ7JirJQ7YEw5O+sI1Pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IzerbmBBB06EHP2p0D6IHLCxy8K0aEHT8ruSSorlmr2/6BncX745MeFGLB7ibsO5M/P7UKaFhPn79tidd9FzrHoqYdP64bn+H45Vcryv9yYJbV6pOkyZ6Ma/O07gXwa1TPO+GZH+V7L878kfR93eg+i6UndbrmxLDewwI0g0q9HVbQ9PigFXlKjfO8ZdNvY1PA+18KhAz5ALQmK2kI7G6e9aRsQ3+SWjSNzCGb+54X5zbYMYIbHWDLNrwCl4j2lxzxPzlsR2ykyAAUPIbR+omk42C5ATW92itgcxBiJf/93GmeW9oGUmGw1Tb8/kbk8yJTTpskXUp+t+fJ2SIT9jsQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
- Cc: "felipe.huici@xxxxxxxxx" <felipe.huici@xxxxxxxxx>, "simon.kuenzer@xxxxxxxxx" <simon.kuenzer@xxxxxxxxx>
- Delivery-date: Mon, 09 Sep 2019 14:21:07 +0000
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
- Thread-index: AQHVY1RB+fM0UxBRnEWzhQ5Au0C+eKcjbPGA
- Thread-topic: [UNIKRAFT/LWIP PATCH 5/5] Makefile.uk: Suppress 'unused parameters' warnings
Hi Costin,
This patch looks good. Thanks!
Vlad
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
On 04.09.2019 22:09, Costin Lupu wrote:
> It's simpler to suppress the warning rather than add '__unused' qualifier each
> time. This also seems it was the initial intention behind using
> '-Wunused-parameter', given that all warnings are enabled by default.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
> Makefile.uk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 99fc062..2292cb4 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -63,7 +63,7 @@ CXXINCLUDES-$(CONFIG_LIBLWIP) += -I$(LIBLWIP_BASE)/include
> -I$(LIBLWIP_EXTRACTED
>
> ################################################################################
> # Library flags
>
> ################################################################################
> -LIBLWIP_CFLAGS-y += -Wno-type-limits -Wunused-parameter
> +LIBLWIP_CFLAGS-y += -Wno-type-limits -Wno-unused-parameter
> LIBLWIP_CFLAGS-$(CONFIG_LWIP_DEBUG) += -DUK_DEBUG
> LIBLWIP_CFLAGS-y += -D__IN_LIBLWIP__
> LIBLWIP_CXXFLAGS-y += -D__IN_LIBLWIP__
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
