Re: [Minios-devel] [UNIKRAFT/LIBLUA PATCH 3/3] Export symbols

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Justin,

Ok, I'll send a v2 that adds those and other symbols and requires newlib in 
Config.uk.

Thanks,

-- Felipe

On 05.09.19, 05:26, "Jia He" <jiakernel2@xxxxxxxxx> wrote:

    Hi Felipe, please see inline below
    
    On 2019/8/28 23:29, Felipe Huici wrote:
    > For now we export all lua_* symbols, include lua_main for the main
    > loop
    >
    > Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
    > Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    > ---
    >   exportsyms.uk | 93 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    >   1 file changed, 93 insertions(+)
    >   create mode 100644 exportsyms.uk
    >
    > diff --git a/exportsyms.uk b/exportsyms.uk
    > new file mode 100644
    > index 0000000..49d712e
    > --- /dev/null
    > +++ b/exportsyms.uk
    > @@ -0,0 +1,93 @@
    > +lua_absindex
    > +lua_arith
    > +lua_atpanic
    > +lua_callk
    > +lua_checkstack
    > +lua_close
    > +lua_compare
    > +lua_concat
    > +lua_copy
    > +lua_createtable
    > +lua_dump
    > +lua_error
    > +lua_gc
    > +lua_getallocf
    > +lua_getfield
    > +lua_getglobal
    > +lua_gethook
    > +lua_gethookcount
    > +lua_gethookmask
    > +lua_geti
    > +lua_getinfo
    > +lua_getlocal
    > +lua_getmetatable
    > +lua_getstack
    > +lua_gettable
    > +lua_gettop
    > +lua_getupvalue
    > +lua_getuservalue
    > +lua_ident
    > +lua_iscfunction
    > +lua_isinteger
    > +lua_isnumber
    > +lua_isstring
    > +lua_isuserdata
    > +lua_isyieldable
    > +lua_len
    > +lua_load
    > +lua_main
    > +lua_newstate
    > +lua_newthread
    > +lua_newuserdata
    > +lua_next
    > +lua_pcallk
    > +lua_pushboolean
    > +lua_pushcclosure
    > +lua_pushfstring
    > +lua_pushinteger
    > +lua_pushlightuserdata
    > +lua_pushlstring
    > +lua_pushnil
    > +lua_pushnumber
    > +lua_pushstring
    > +lua_pushthread
    > +lua_pushvalue
    > +lua_pushvfstring
    > +lua_rawequal
    > +lua_rawget
    > +lua_rawgeti
    > +lua_rawgetp
    > +lua_rawlen
    > +lua_rawset
    > +lua_rawseti
    > +lua_rawsetp
    > +lua_resume
    > +lua_rotate
    > +lua_setallocf
    > +lua_setfield
    > +lua_setglobal
    > +lua_sethook
    > +lua_seti
    > +lua_setlocal
    > +lua_setmetatable
    > +lua_settable
    > +lua_settop
    > +lua_setupvalue
    > +lua_setuservalue
    > +lua_status
    > +lua_stringtonumber
    > +lua_toboolean
    > +lua_tocfunction
    > +lua_tointegerx
    > +lua_tolstring
    > +lua_tonumberx
    > +lua_topointer
    > +lua_tothread
    > +lua_touserdata
    > +lua_type
    > +lua_typename
    > +lua_upvalueid
    > +lua_upvaluejoin
    > +lua_version
    > +lua_xmove
    > +lua_yieldk
    
    I ran a simple test file for lua
    #include <string.h>
    
    #include "lua.h"
    #include <lauxlib.h>
    #include <lualib.h>
    
    int main()
    {
         char buff[256] = {0};
         int error;
         lua_State *L = luaL_newstate();
         luaL_openlibs(L);
         while (fgets(buff, sizeof(buff), stdin) != NULL)
         {
             error = luaL_loadbuffer(L, buff, strlen(buff), "line")
                 || lua_pcall(L, 0, 0, 0);
             if (error)
             {
                 fprintf(stderr, "%s", lua_tostring(L, -1));
                 lua_pop(L, 1);
             }
         }
    
         lua_close(L);
         return 0;
    }
         
    Seems you have to export more(not the full list) symbols
    luaL_newstate
    luaL_openlibs
    luaL_loadbufferx
    
    Otherwise, it reports error when linking liblua.
    
    ---
    Cheers,
    Justin (Jia He)
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel