[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH V3 0/6] Enable solo5 platform support



Hi Haibo, 

Thanks for the config file. The problem was that I had uksched selected, but we 
only support x86 for now, this was causing the linker errors. I'll now move on 
with the solo5 review, and I should probably submit a patch to uksched's 
Config.uk so that this can't happen again.

-- Felipe

On 22.08.19, 02:22, "Haibo Xu (Arm Technology China)" <haibo.xu@xxxxxxx> wrote:

    Hi Felipe,
    
    Previously, I used a old version of the staging branch with 
commit(0ab2d365fc1f) timed at Aug 9.
    Then I tried the latest version with commit(1181756d0782e8) timed at Aug 21 
which also works well.
    BTW, I have attached the helloworld ".config" file for your reference.
    
    Regards,
    Haibo
    
    On 2019/8/21 23:04, Felipe Huici wrote:
    > Hi Haibo,
    >
    > Yes, those are the steps I had done, are you sure you were up to date 
with the latest version of the staging branch before you applied the external 
platform series?
    >
    > Thanks,
    >
    > -- Felipe
    >
    > On 21.08.19, 13:26, "Haibo Xu (Arm Technology China)" <Haibo.Xu@xxxxxxx> 
wrote:
    >
    >     Hi Felipe,
    >
    >     I have verified the build with helloworld app, and it works well.
    >     You can following the below steps to have a try.
    >
    >     Regards,
    >     Haibo
    >     ___________________________________________________
    >     1. Include Simon's patch to support external platform 
library(https://lists.xenproject.org/archives/html/minios-devel/2019-05/msg00165.html)
    >     2. put this patch into a dedicated directory(as an external platform 
library)-> attachment 1.PNG
    >     3. Change the helloworld app Makefile to include the external 
platform -> attachment 2.PNG
    >     4. Configure the helloworld app to use "solo5" platform, and then 
build the app.
    >          In the helloworld/build directory, you will find the monitor and 
app binary. -> attachment 3.PNG
    >
    >     > -----Original Message-----
    >     > From: Felipe Huici <Felipe.Huici@xxxxxxxxx>
    >     > Sent: 2019年8月21日 18:35
    >     > To: Haibo Xu (Arm Technology China) <Haibo.Xu@xxxxxxx>; minios-
    >     > devel@xxxxxxxxxxxxx
    >     > Cc: florian.schmidt@xxxxxxxxx; Simon Kuenzer 
<simon.kuenzer@xxxxxxxxx>
    >     > Subject: Re: [Minios-devel] [UNIKRAFT PATCH V3 0/6] Enable solo5 
platform
    >     > support
    >     >
    >     > Hi Haibo,
    >     >
    >     > Thanks a lot for the patches. It tried compiling this but I get the 
following
    >     > linker error:
    >     >
    >     > # gcc  -nostdinc -nostdlib -Wl,--omagic -Wl,--build-id=none  
-Wl,--gc-sections
    >     > -no-pie  -Wl,-m,elf_x86_64 -Wl,-
    >     > 
dT,/root/workspace/gitlab/unikraft/upstreaming/plats/solo5/link64.lds -Wl,-
    >     > 
T/root/workspace/gitlab/unikraft/upstreaming/unikraft/lib/ukdebug/extra.l
    >     > d -Wl,-
    >     > 
T/root/workspace/gitlab/unikraft/upstreaming/unikraft/lib/vfscore/extra.ld
    >     > 
/root/workspace/gitlab/unikraft/upstreaming/apps/helloworld/build/hellow
    >     > orld_solo5-x86_64.o
    >     > 
/root/workspace/gitlab/unikraft/upstreaming/apps/helloworld/build/libsolo
    >     > 5/origin/solo5-0.4.1/bindings/hvt/solo5_hvt.o -o
    >     > 
/root/workspace/gitlab/unikraft/upstreaming/apps/helloworld/build/hellow
    >     > orld_solo5-x86_64
    >     > /usr/bin/ld: .comment not found for insert
    >     >
    >     > If I add a lilne to put that section in, I then get undefined 
reference errors for
    >     > _tls_start and _tls_end . Both these symbols and the .comment line 
appear in
    >     > the internal platforms' linker scripts. Does this actually build 
for you?
    >     >
    >     > Thanks,
    >     >
    >     > -- Felipe
    >     >
    >     > On 16.08.19, 04:59, "Minios-devel on behalf of Haibo Xu" 
<minios-devel-
    >     > bounces@xxxxxxxxxxxxxxxxxxxx on behalf of haibo.xu@xxxxxxx> wrote:
    >     >
    >     >     Hi,
    >     >
    >     >     As discussed with Simon and Ricardo in the email loop,
    >     >     Solo5(formerly known as ukvm) would make most sense as
    >     >     another and new platform library for the unikraft, this
    >     >     patch set will try to enable the solo5 platform support.
    >     >
    >     >     Currently, the implementation has been tested with the
    >     >     hello-world application on both x86-64 and arm64 machine.
    >     >
    >     >     v1->v2:
    >     >             - add a menu option to solo5 platform that enable
    >     >               build of solo5 monitor;
    >     >             - change the solo5 src codes download method, and
    >     >               use the unikraft build system "fetch" and "extract"
    >     >               method.
    >     >     v2->v3:
    >     >             - put the solo5 as an external platform.
    >     >
    >     >     Regards,
    >     >
    >     >     Haibo
    >     >
    >     >     Haibo Xu (6):
    >     >       Add basic documentations.
    >     >       external plat: Add the solo5 API declaration in solo5.h
    >     >       external plat: Add solo5 platform Config.uk file
    >     >       external plat: Add solo5 platform link files.
    >     >       external plat: Add solo5 platform Makefile.uk
    >     >       external plat: Add platform interface implementation
    >     >
    >     >      CODING_STYLE.md       |   4 +
    >     >      CONTRIBUTING.md       |   4 +
    >     >      COPYING.md            |  46 +++++++
    >     >      Config.uk             |  17 +++
    >     >      Linker.uk             |  61 +++++++++
    >     >      MAINTAINERS.md        |  11 ++
    >     >      Makefile.uk           |  56 +++++++++
    >     >      README.md             |   5 +
    >     >      console.c             |  45 +++++++
    >     >      include/solo5/setup.h |  49 ++++++++
    >     >      include/solo5/solo5.h | 280
    >     > ++++++++++++++++++++++++++++++++++++++++++
    >     >      io.c                  |  41 +++++++
    >     >      irq.c                 |  28 +++++
    >     >      lcpu.c                |  75 +++++++++++
    >     >      link64.lds            | 119 ++++++++++++++++++
    >     >      memory.c              |  81 ++++++++++++
    >     >      setup.c               |  42 +++++++
    >     >      shutdown.c            |  37 ++++++
    >     >      time.c                |  56 +++++++++
    >     >      19 files changed, 1057 insertions(+)
    >     >      create mode 100644 CODING_STYLE.md
    >     >      create mode 100644 CONTRIBUTING.md
    >     >      create mode 100644 COPYING.md
    >     >      create mode 100644 Config.uk
    >     >      create mode 100644 Linker.uk
    >     >      create mode 100644 MAINTAINERS.md
    >     >      create mode 100644 Makefile.uk
    >     >      create mode 100644 README.md
    >     >      create mode 100644 console.c
    >     >      create mode 100644 include/solo5/setup.h
    >     >      create mode 100644 include/solo5/solo5.h
    >     >      create mode 100644 io.c
    >     >      create mode 100644 irq.c
    >     >      create mode 100644 lcpu.c
    >     >      create mode 100644 link64.lds
    >     >      create mode 100644 memory.c
    >     >      create mode 100644 setup.c
    >     >      create mode 100644 shutdown.c
    >     >      create mode 100644 time.c
    >     >
    >     >     --
    >     >     2.17.1
    >     >
    >     >
    >     >     _______________________________________________
    >     >     Minios-devel mailing list
    >     >     Minios-devel@xxxxxxxxxxxxxxxxxxxx
    >     >     https://lists.xenproject.org/mailman/listinfo/minios-devel
    >
    >     IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
    >
    >
    
    IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.