Re: [Minios-devel] [UNIKRAFT PATCHv2 2/3] build: Split ofw from kvm plat to independent library

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello,

This patch seems fine. I have a minor comment.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

Thanks & Regards

Sharan

On 8/15/19 9:16 AM, Jia He wrote:
> This patch splits the device tree driver as a separate library from the kvm
> platform library. This is similar to what we do for virtio or pci drivers
>
> The discussion is at [1].
> [1] 
> https://lists.xenproject.org/archives/html/minios-devel/2019-07/msg00046.html
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> Suggested-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
> ---
>   plat/kvm/Config.uk   |  6 ++++++
>   plat/kvm/Makefile.uk | 11 ++++++++++-
>   2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/plat/kvm/Config.uk b/plat/kvm/Config.uk
> index 39da143..e620966 100644
> --- a/plat/kvm/Config.uk
> +++ b/plat/kvm/Config.uk
> @@ -87,4 +87,10 @@ config LIBGICV2
>          select LIBOFW
>          depends on ARCH_ARM_64
>   
> +config LIBOFW
> +       bool "Open Firmware library support"
> +       default n
> +       select LIBFDT
> +       depends on ARCH_ARM_64
> +
>   endif
> diff --git a/plat/kvm/Makefile.uk b/plat/kvm/Makefile.uk
> index b1fd50b..53432fa 100644
> --- a/plat/kvm/Makefile.uk
> +++ b/plat/kvm/Makefile.uk
> @@ -10,6 +10,7 @@ $(eval $(call addplatlib,kvm,libkvmplat))
>   $(eval $(call addplatlib_s,kvm,libkvmpci,$(CONFIG_KVM_PCI)))
>   $(eval $(call addplatlib_s,kvm,libkvmvirtio,$(CONFIG_VIRTIO_BUS)))
>   $(eval $(call addplatlib_s,kvm,libkvmvirtionet,$(CONFIG_VIRTIO_NET)))
> +$(eval $(call addplatlib_s,kvm,libkvmofw,$(CONFIG_LIBOFW)))
>   $(eval $(call addplatlib_s,kvm,libkvmgicv2,$(CONFIG_LIBGICV2)))
>   
>   ##
> @@ -67,7 +68,6 @@ LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/cache64.S|co
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/psci_arm64.S|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/time.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_COMMON_BASE)/arm/traps.c|common
> -LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += 
> $(UK_PLAT_DRIVERS_BASE)/ofw/fdt.c|common
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/entry64.S
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/exceptions.S
>   LIBKVMPLAT_SRCS-$(CONFIG_ARCH_ARM_64) += $(LIBKVMPLAT_BASE)/arm/pagetable64.S
> @@ -119,6 +119,15 @@ LIBKVMVIRTIONET_CINCLUDES-y    += 
> -I$(UK_PLAT_DRIVERS_BASE)/include
>   LIBKVMVIRTIONET_SRCS-y +=\
>                         $(UK_PLAT_DRIVERS_BASE)/virtio/virtio_net.c
>   
> +##
> +## OFW library definitions
> +##
> +LIBKVMOFW_CINCLUDES-y         += -I$(LIBKVMPLAT_BASE)/include
> +LIBKVMOFW_CINCLUDES-y         += -I$(UK_PLAT_COMMON_BASE)/include
> +LIBKVMOFW_CINCLUDES-y         += -I$(UK_PLAT_DRIVERS_BASE)/include
> +
> +LIBKVMOFW_SRCS-$(CONFIG_LIBOFW)      += $(UK_PLAT_DRIVERS_BASE)/ofw/fdt.c
We wouldn't need CONFIG_LIBOFW here?
> +
>   ##
>   ## GICv2 library definitions
>   ##
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel