Re: [Minios-devel] [UNIKRAFT PATCH v3 6/8] build: Print linker script files

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Sharan,

I think the commit message could be a bit more descriptive, saying that this 
adds a make target that prints the paths to the linker script files, but I can 
fix this on upstream.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 12.08.19, 16:04, "Minios-devel on behalf of Sharan Santhanam" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
Sharan.Santhanam@xxxxxxxxx> wrote:

    Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
    ---
     Makefile                      | 14 ++++++++++++++
     doc/guides/developers-app.rst |  1 +
     2 files changed, 15 insertions(+)
    
    diff --git a/Makefile b/Makefile
    index 0570db51..78618c21 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -751,6 +751,19 @@ print-libs:
                )))) \
                $(UK_LIBS) $(UK_LIBS-y)
     
    +print-lds:
    +   @echo -e \
    +           $(foreach P,$(UK_PLATS) $(UK_PLATS-y),\
    +           $(if $(call qstrip,$($(call uc,$(P))_LIBS) $($(call 
uc,$(P))_LIBS-y)),\
    +           $(foreach L,$($(call uc,$(P))_LIBS) $($(call uc,$(P))_LIBS-y), \
    +           $(if $(call qstrip,$($(call vprefix_lib,$(L),LDS)) $($(call 
vprefix_lib,$(L),LDS-y))), \
    +           '$(L):\n   $($(call vprefix_lib,$(L),LDS)) $($(call 
vprefix_lib,$(L),LDS-y))\n'\
    +           ))))\
    +           $(foreach L,$(UK_LIBS) $(UK_LIBS-y),\
    +           $(if $(call qstrip,$($(call vprefix_lib,$(L),LDS)) $($(call 
vprefix_lib,$(L),LDS-y))),\
    +           '$(L):\n   $($(call vprefix_lib,$(L),LDS)) $($(call 
vprefix_lib,$(L),LDS-y))\n'\
    +           ))
    +
     print-objs:
        @echo -e \
                $(foreach P,$(UK_PLATS) $(UK_PLATS-y),\
    @@ -826,6 +839,7 @@ help:
        @echo 'Miscellaneous:'
        @echo '  print-version          - print Unikraft version'
        @echo '  print-libs             - print library names enabled for build'
    +   @echo '  print-lds              - print linker script enabled for the 
build'
        @echo '  print-objs             - print object file names enabled for 
build'
        @echo '  print-srcs             - print source file names enabled for 
build'
        @echo '  print-vars             - prints all the variables currently 
defined in Makefile'
    diff --git a/doc/guides/developers-app.rst b/doc/guides/developers-app.rst
    index fdde5dad..8e1698b1 100644
    --- a/doc/guides/developers-app.rst
    +++ b/doc/guides/developers-app.rst
    @@ -417,6 +417,7 @@ below: ::
       Miscellaneous:
       print-version          - print Unikraft version
       print-libs             - print library names enabled for build
    +  print-lds              - print linker script enabled for the build
       print-objs             - print object file names enabled for build
       print-srcs             - print source file names enabled for build
       print-vars             - prints all the variables currently defined in 
Makefile
    -- 
    2.20.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel