Re: [Minios-devel] [UNIKRAFT PATCH 1/4] lib/posix-libdl: Introduce POSIX libdl library skeleton

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi,

This patch looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 14.08.19, 16:56, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    A great number of libraries use explicit loading of dynamic libraries and 
for
    this reason we provide the libdl Unikraft implementation. Given that libdl 
is
    POSIX, we propose a new name convention for internal libraries which 
implement
    POSIX functions: every internal library will have the 'posix-' prefix in 
order
    to differentiate it from libraries that implement Unikraft specific
    functionalities.
    
    Signed-off-by: Andrei Gogonea <andrei.gogonea09@xxxxxxxxx>
    Signed-off-by: Teodora Serbanescu <teo.serbanescu16@xxxxxxxxx>
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     lib/Config.uk                 | 1 +
     lib/Makefile.uk               | 1 +
     lib/posix-libdl/Config.uk     | 3 +++
     lib/posix-libdl/Makefile.uk   | 4 ++++
     lib/posix-libdl/exportsyms.uk | 1 +
     5 files changed, 10 insertions(+)
     create mode 100644 lib/posix-libdl/Config.uk
     create mode 100644 lib/posix-libdl/Makefile.uk
     create mode 100644 lib/posix-libdl/exportsyms.uk
    
    diff --git a/lib/Config.uk b/lib/Config.uk
    index f61d3b1e..e97a9af3 100644
    --- a/lib/Config.uk
    +++ b/lib/Config.uk
    @@ -49,3 +49,4 @@ source "lib/ukswrand/Config.uk"
     source "lib/ukbus/Config.uk"
     source "lib/uksglist/Config.uk"
     source "lib/uknetdev/Config.uk"
    +source "lib/posix-libdl/Config.uk"
    diff --git a/lib/Makefile.uk b/lib/Makefile.uk
    index b7ad6287..b41345de 100644
    --- a/lib/Makefile.uk
    +++ b/lib/Makefile.uk
    @@ -26,3 +26,4 @@ $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukmpi))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/ukbus))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uksglist))
     $(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/uknetdev))
    +$(eval $(call _import_lib,$(CONFIG_UK_BASE)/lib/posix-libdl))
    diff --git a/lib/posix-libdl/Config.uk b/lib/posix-libdl/Config.uk
    new file mode 100644
    index 00000000..f2d2fb24
    --- /dev/null
    +++ b/lib/posix-libdl/Config.uk
    @@ -0,0 +1,3 @@
    +config POSIX_LIBDL
    +   bool "libdl: POSIX libdl library"
    +   default n
    diff --git a/lib/posix-libdl/Makefile.uk b/lib/posix-libdl/Makefile.uk
    new file mode 100644
    index 00000000..4e5109a5
    --- /dev/null
    +++ b/lib/posix-libdl/Makefile.uk
    @@ -0,0 +1,4 @@
    +$(eval $(call addlib_s,posix_libdl,$(CONFIG_POSIX_LIBDL)))
    +
    +CINCLUDES-$(CONFIG_POSIX_LIBDL)    += -I$(POSIX_LIBDL_BASE)/include
    +CXXINCLUDES-$(CONFIG_POSIX_LIBDL)  += -I$(POSIX_LIBDL_BASE)/include
    diff --git a/lib/posix-libdl/exportsyms.uk b/lib/posix-libdl/exportsyms.uk
    new file mode 100644
    index 00000000..621e94f0
    --- /dev/null
    +++ b/lib/posix-libdl/exportsyms.uk
    @@ -0,0 +1 @@
    +none
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel