Re: [Minios-devel] [UNIKRAFT/LIBZLIB PATCH v3 1/3] Introduce library skeleton

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin,

On 14.08.19, 14:58, "Costin Lupu" <costin.lup@xxxxxxxxx> wrote:

    Hi Felipe,
    
    This patch should also add `.gitignore`. You can simply copy it from
    here: https://github.com/unikraft/pcre/blob/master/.gitignore . This is
    the one we are using almost everywhere.

Forgot to add it, will add it in v4.
    
    Please see another comment inline.
    
    On 8/14/19 11:36 AM, Felipe Huici wrote:
    > We use the BSD-3-Clause license for this library glue code.
    > 
    > Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
    > ---
    >  CODING_STYLE.md |  4 ++++
    >  CONTRIBUTING.md |  4 ++++
    >  COPYING.md      | 39 +++++++++++++++++++++++++++++++++++++++
    >  Config.uk       |  7 +++++++
    >  MAINTAINERS.md  | 10 ++++++++++
    >  README.md       |  6 ++++++
    >  exportsyms.uk   |  1 +
    >  7 files changed, 71 insertions(+)
    >  create mode 100644 CODING_STYLE.md
    >  create mode 100644 CONTRIBUTING.md
    >  create mode 100644 COPYING.md
    >  create mode 100644 Config.uk
    >  create mode 100644 MAINTAINERS.md
    >  create mode 100644 README.md
    >  create mode 100644 exportsyms.uk
    > 
    > diff --git a/CODING_STYLE.md b/CODING_STYLE.md
    > new file mode 100644
    > index 0000000..5730041
    > --- /dev/null
    > +++ b/CODING_STYLE.md
    > @@ -0,0 +1,4 @@
    > +Coding Style
    > +============
    > +
    > +Please refer to the `CODING_STYLE.md` file in the main Unikraft 
repository.
    > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
    > new file mode 100644
    > index 0000000..5f55eca
    > --- /dev/null
    > +++ b/CONTRIBUTING.md
    > @@ -0,0 +1,4 @@
    > +Contributing to Unikraft
    > +=======================
    > +
    > +Please refer to the `CONTRIBUTING.md` file in the main Unikraft 
repository.
    > diff --git a/COPYING.md b/COPYING.md
    > new file mode 100644
    > index 0000000..973051a
    > --- /dev/null
    > +++ b/COPYING.md
    > @@ -0,0 +1,39 @@
    > +License
    > +=======
    > +
    > +Unikraft zlib wrappers
    > +------------------------
    > +
    > +This repository contains wrapper code to build zlib with Unikraft.
    > +Each C code file in this repository should declare who is the
    > +copyright owner and under which terms and conditions the code is
    > +licensed. If such a licence note is missing, the following copyright
    > +notice will apply:
    > +
    > + Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights 
reserved.
    > +
    > + Redistribution and use in source and binary forms, with or without
    > + modification, are permitted provided that the following conditions
    > + are met:
    > +
    > + 1. Redistributions of source code must retain the above copyright
    > +    notice, this list of conditions and the following disclaimer.
    > + 2. Redistributions in binary form must reproduce the above copyright
    > +    notice, this list of conditions and the following disclaimer in the
    > +    documentation and/or other materials provided with the distribution.
    > + 3. Neither the name of the copyright holder nor the names of its
    > +    contributors may be used to endorse or promote products derived from
    > +    this software without specific prior written permission.
    > +
    > + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
    > + AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    > + IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    > + ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
BE
    > + LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    > + CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    > + SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
    > + INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
    > + CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    > + ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
THE
    > + POSSIBILITY OF SUCH DAMAGE.
    > +
    > diff --git a/Config.uk b/Config.uk
    > new file mode 100644
    > index 0000000..3734adb
    > --- /dev/null
    > +++ b/Config.uk
    > @@ -0,0 +1,7 @@
    > +config LIBZLIB
    > +    bool "zlib - a compression library"
    > +    default y
    > +    depends on HAVE_LIBC
    > +    select LIBVFSCORE
    > +    select LIBRAMFS
    > +    select LIBDEVFS
    > \ No newline at end of file
    > diff --git a/MAINTAINERS.md b/MAINTAINERS.md
    > new file mode 100644
    > index 0000000..5a4abc4
    > --- /dev/null
    > +++ b/MAINTAINERS.md
    > @@ -0,0 +1,10 @@
    > +Maintainers List
    > +================
    > +
    > +For notes on how to read this information, please refer to 
`MAINTAINERS.md` in
    > +the main Unikraft repository.
    > +
    > + LIBUUID-UNIKRAFT
    
    s/LIBUUID/LIBZLIB/g

Will fix.

Thanks,

-- Felipe
    
    > + M:      Felipe Huici <felipe.huici@xxxxxxxxx>
    > + L:      minios-devel@xxxxxxxxxxxxx
    > + F: *
    > diff --git a/README.md b/README.md
    > new file mode 100644
    > index 0000000..82f3c44
    > --- /dev/null
    > +++ b/README.md
    > @@ -0,0 +1,6 @@
    > +libzlib for Unikraft
    > +===================
    > +This is a port of zlib to Unikraft. 
    > +
    > +Please refer to the `README.md` as well as the documentation in the 
`doc/`
    > +subdirectory of the main unikraft repository for further information.
    > diff --git a/exportsyms.uk b/exportsyms.uk
    > new file mode 100644
    > index 0000000..c86c3f3
    > --- /dev/null
    > +++ b/exportsyms.uk
    > @@ -0,0 +1 @@
    > +none
    > \ No newline at end of file
    > 
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel