[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [PATCH] include/netinet/tcp.h: Remove TCP_MSS definition


  • To: minios-devel@xxxxxxxxxxxxx
  • From: Costin Lupu <costin.lupu@xxxxxxxxx>
  • Date: Sun, 23 Jun 2019 21:29:39 +0300
  • Cc: felipe.huici@xxxxxxxxx, simon.kuenzer@xxxxxxxxx, vlad_andrei.badoiu@xxxxxxxxxxxxxxx, sharan.santhanam@xxxxxxxxx
  • Delivery-date: Sun, 23 Jun 2019 18:29:48 +0000
  • Ironport-phdr: 9a23:IXrq3BZOHrWLIhL4exuNFcf/LSx+4OfEezUN459isYplN5qZpsy8bB7h7PlgxGXEQZ/co6odzbaP6ea5ASdZu8fJ8ChbNsAVDlld0YRetjdjKfbNMVf8Iv/uYn5yN+V5f3ghwUuGN1NIEt31fVzYry76xzcTHhLiKVg9fbytScbdgMutyu+95YDYbRlWizqhe7NyKwi9oRnMusUMjoZuN7g9xgHUrndUdOha2H1kKFaOlBr4+su84YRv/itNt/487cJMTbn2c6ElRrFEEToqNHw46tf2vhfZVwuP4XUcUmQSkhVWBgXO8Q/3UJTsvCbkr+RxwCaVM9H4QrAyQjSi8rxkSAT0hycdNj4263/Yh8pth69Guh2hphh/w4nJYIGJMfd1Y63Qcc8GSWdHQ81cUTFKDIGhYIsVF+cPIPhWr4f9qVUNoxWxCwajC+HzxTFHnXL2wa833v49HQ3a0gEtHdQDu2nUotXvM6cSVPi4wbfPzTXYc/NW2DH945XOfBA8ufGMQK97fM3NxkkoDAPFklSQqYr/MzORy+QNq3Wb4vF8WuK0kWInsxxxrSO1ysc2jYnEn4QYwU3H+yVh2Is5ONK1RFNhbdOnEJZcrT+WO5V0T884TWxkoCY3xqcbtZKlZiQG1pQqyhDFZ/Cab4SF4xTuX/uLLzhinnJqYre/ig638Uin1+LzSNG50E1PripZitnMsW0N1wDL5siHVPR9+kCh1C6R1wDW8O5EIEQ0mbDHJJ462LIwjocTvl/ZEi/sn0X6lK6WdkM69ei08+nrf7rrqoKGO4J3igzyKLoiltK9DOgiPAUCR22b9v691L3n8035WrJKjvgun6bFt5DaPtgbpq+/AwNP1oYj9g6/Dyq93dsEhnkLNkpFeA+cgITzIVHOJ+j0De2jjFS0jDdr2/fGM6XkApXMKHjDkbDhfa1k50FB1gUz085Q55ZPB7EFIfLzQVPxtMfCAh42LQO0xfzrCNJn1oMRQWiPGLOWMLvOsV+U4eIiO+eMa5ERuDb8M/gq+eTijX8kmV8cYaap3IAaaHamEft6J0WWe2Hjjs0fHmcXpgA+VvDliEWeUT5PYHa/R7k85jEhB4K8F4jDQJqhgKeb0ye9Ap1WZnpJClaWHnftbIiEXekDZz6WIsB7iTMIT6auS5I53xG0qAD606ZnLvbT+iAArpLj1d115+rVlR0o9jx0EtqS02eMTm5qhGMFXDk2075jrkx50FiMyrJ0jOJFFdZL/fNGTh86NYLAz+x9E93yRAbBcc2UR1m+WNqmByw+TsgvzN8PeUpyAM+tgQ3E3yqrHr8YjKeLBIAp8q3BxXT+Pdpyy23c2Kk8l1kpWdFDNXehhv03yw+GAo/PkkKC0qqna6kY9CrM73uYi3qDugdfSgEjf7/CWCU0YVDKrNKxwl7aUvf6ArM8LgpHj8qfMrZiYcavlUhMAu3kboeNK1mtknu9UE7bjoiHa5DnLj0Q
  • Ironport-sdr: 97MqGl2uKRybyzITd5mknSAdCOGrV0gvKq23ZgF7T35WQa3jPbrpyB7C9vaFjUiti8ytTstsgZ H27Q6DnXCS5Q==
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>

Hi,

This is a UNIKRAFT/LWIP patch. I forgot to set the prefix, sorry.

Thanks,
Costin

On 6/23/19 9:25 PM, Costin Lupu wrote:
> TCP_MSS definition is already provided by lwipopts.h.
> 
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> ---
>  include/netinet/tcp.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/netinet/tcp.h b/include/netinet/tcp.h
> index 6b77ff6..0090407 100644
> --- a/include/netinet/tcp.h
> +++ b/include/netinet/tcp.h
> @@ -79,14 +79,6 @@ struct tcphdr {
>  #define TCPOPT_TSTAMP_HDR    \
>      (TCPOPT_NOP<<24|TCPOPT_NOP<<16|TCPOPT_TIMESTAMP<<8|TCPOLEN_TIMESTAMP)
>  
> -/*
> - * Default maximum segment size for TCP.
> - * With an IP MSS of 576, this is 536,
> - * but 512 is probably more convenient.
> - * This should be defined as MIN(512, IP_MSS - sizeof (struct tcpiphdr)).
> - */
> -#define      TCP_MSS 512
> -
>  #define      TCP_MAXWIN      65535   /* largest value for (unscaled) window 
> */
>  
>  #define TCP_MAX_WINSHIFT     14      /* maximum window shift */
> 

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.