Re: [Minios-devel] [UNIKRAFT early RFC PATCH 03/11] plat/kvm/smp: Add psci call definitions in psci.h

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

NIT: PSCI is acronym should it should be upper case. Note it is ok for the 
header to be an lower case.
On 21/06/2019 07:57, Jia He wrote:
> Add psci call definitions in psci.h
Same here.

> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/common/include/arm/psci.h | 87 ++++++++++++++++++++++++++++++++++
>   1 file changed, 87 insertions(+)
>   create mode 100644 plat/common/include/arm/psci.h
>
> diff --git a/plat/common/include/arm/psci.h b/plat/common/include/arm/psci.h
> new file mode 100644
> index 0000000..28c9d9d
> --- /dev/null
> +++ b/plat/common/include/arm/psci.h
> @@ -0,0 +1,87 @@
> +/* SPDX-License-Identifier: BSD-3-Clause */
> +/*
> + * Authors: Jia He <justin.he@xxxxxxx>
> + *
> + * Copyright (c) 2019, Arm Ltd. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of the copyright holder nor the names of its
> + *    contributors may be used to endorse or promote products derived from
> + *    this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
> + */
> +
> +#ifndef __PLAT_CMN_ARM_PSCI_H__
> +#define __PLAT_CMN_ARM_PSCI_H__
> +
> +/*
> + * PSCI function codes (as per PSCI v0.2).
1.0 has been released in 2015, and 0.2 is much ancient (2013). Don't you want to 
get something a bit more recent?
> + */
> +#ifdef __aarch64__
> +#define        PSCI_FNID_VERSION               0x84000000
> +#define        PSCI_FNID_CPU_SUSPEND           0xc4000001
> +#define        PSCI_FNID_CPU_OFF               0x84000002
> +#define        PSCI_FNID_CPU_ON                0xc4000003
> +#define        PSCI_FNID_AFFINITY_INFO         0xc4000004
> +#define        PSCI_FNID_MIGRATE               0xc4000005
> +#define        PSCI_FNID_MIGRATE_INFO_TYPE     0x84000006
> +#define        PSCI_FNID_MIGRATE_INFO_UP_CPU   0xc4000007
> +#define        PSCI_FNID_SYSTEM_OFF            0x84000008
> +#define        PSCI_FNID_SYSTEM_RESET          0x84000009
> +#define        PSCI_FNID_FEATURES              0x8400000a
> +#else
> +#define        PSCI_FNID_VERSION               0x84000000
> +#define        PSCI_FNID_CPU_SUSPEND           0x84000001
> +#define        PSCI_FNID_CPU_OFF               0x84000002
> +#define        PSCI_FNID_CPU_ON                0x84000003
> +#define        PSCI_FNID_AFFINITY_INFO         0x84000004
> +#define        PSCI_FNID_MIGRATE               0x84000005
> +#define        PSCI_FNID_MIGRATE_INFO_TYPE     0x84000006
> +#define        PSCI_FNID_MIGRATE_INFO_UP_CPU   0x84000007
> +#define        PSCI_FNID_SYSTEM_OFF            0x84000008
> +#define        PSCI_FNID_SYSTEM_RESET          0x84000009
> +#define        PSCI_FNID_FEATURES              0x8400000a
> +#endif
There are a lot here duplicated. Could you do something to avoid that?

For instance, you could define PSCI_FN32_* and PSCI_FN64_*. Some of the FN32 
would be used for both arm64 and arm32.
> +
> +enum psci_function {
> +       PSCI_FN_CPU_SUSPEND,
> +       PSCI_FN_CPU_ON,
> +       PSCI_FN_CPU_OFF,
> +       PSCI_FN_MIGRATE,
> +       PSCI_FN_MAX,
> +};
What's this enum exactly for?

> +
> +/* PSCI return values (inclusive of all PSCI versions) */
> +#define PSCI_RET_SUCCESS                       0
> +#define PSCI_RET_NOT_SUPPORTED                 -1
> +#define PSCI_RET_INVALID_PARAMS                        -2
> +#define PSCI_RET_DENIED                                -3
> +#define PSCI_RET_ALREADY_ON                    -4
> +#define PSCI_RET_ON_PENDING                    -5
> +#define PSCI_RET_INTERNAL_FAILURE              -6
> +#define PSCI_RET_NOT_PRESENT                   -7
> +#define PSCI_RET_DISABLED                      -8
> +#define PSCI_RET_INVALID_ADDRESS               -9
> +
> +#endif /* __PLAT_CMN_ARM_IRQ_H__ */
s/IRQ/PSCI/


>
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel