Re: [Minios-devel] [UNIKRAFT/LIBFXDIV PATCH 3/3] Initial port of fxdiv to Unikraft

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad,

Please see some minor comments inline.

Thanks,

-- Felipe

On 10.06.19, 01:13, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    This is our initial port of fxdiv to Unikraft as an external library. 
Libcxx is
    required. When adding the library to the dependency list it should stay 
after
    libcxx (e.g. ...:$(UK_LIBS)/libcxx:$(UK_LIBS)/libfxdiv:...).

> This is somewhat misleading, since libcxx depends on other libraries (one 
> might be tempted to copy and paste your line and expect things to work). 
> Perhaps you can give a fuller, working example?
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     Config.uk     |  5 ++++
     Makefile.uk   | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++
     exportsyms.uk |  1 +
     3 files changed, 80 insertions(+)
     create mode 100644 Config.uk
     create mode 100644 Makefile.uk
     create mode 100644 exportsyms.uk
    
    diff --git a/Config.uk b/Config.uk
    new file mode 100644
    index 0000000..0fc7ca8
    --- /dev/null
    +++ b/Config.uk
    @@ -0,0 +1,5 @@
    +menuconfig LIBFXDIV
    +    bool "C99/C++ header-only library for division via fixed-point 
multiplication by inverse"

> Perhaps we can make this a bit shorter for menu readiblity purposes? Maybe 
> remove "header-only"?

    +    select LIBCXX
    +    default n
    +
    diff --git a/Makefile.uk b/Makefile.uk
    new file mode 100644
    index 0000000..a1ac065
    --- /dev/null
    +++ b/Makefile.uk
    @@ -0,0 +1,74 @@
    +#  libfxdiv config file
    +#
    +#  Authors: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    +#
    +#  Copyright (c) 2019, University Politehnica of Bucharest. All rights 
reserved.
    +#
    +#  Redistribution and use in source and binary forms, with or without
    +#  modification, are permitted provided that the following conditions
    +#  are met:
    +#
    +#  1. Redistributions of source code must retain the above copyright
    +#     notice, this list of conditions and the following disclaimer.
    +#  2. Redistributions in binary form must reproduce the above copyright
    +#     notice, this list of conditions and the following disclaimer in the
    +#     documentation and/or other materials provided with the distribution.
    +#  3. Neither the name of the copyright holder nor the names of its
    +#     contributors may be used to endorse or promote products derived from
    +#     this software without specific prior written permission.
    +#
    +#  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
    +#  AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
    +#  IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    +#  ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
BE
    +#  LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
    +#  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
    +#  SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
    +#  INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
    +#  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
    +#  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
THE
    +#  POSSIBILITY OF SUCH DAMAGE.
    +#
    +#  THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
    +
    
+################################################################################
    +# Library registration
    
+################################################################################
    +$(eval $(call addlib_s,libfxdiv,$(CONFIG_LIBFXDIV)))
    +
    
+################################################################################
    +# Sources
    
+################################################################################
    +LIBFXDIV_VERSION=master
    +LIBFXDIV_URL=https://github.com/Maratyszcza/FXdiv/archive/master.zip

> I was wondering whether we shouldn't freeze this against a particular commit, 
> although given that the last commit was in Nov 2018, perhaps this project 
> isn't changing much anyways?

    +LIBFXDIV_PATCHDIR=$(LIBFXDIV_BASE)/patches
    +$(eval $(call fetch,libfxdiv,$(LIBFXDIV_URL)))
    +
    
+################################################################################
    +# Helpers
    
+################################################################################
    +LIBFXDIV_SUBDIR=FXdiv-master
    +LIBFXDIV_SRC=$(LIBFXDIV_ORIGIN)/$(LIBFXDIV_SUBDIR)
    +
    
+################################################################################
    +# Library includes
    
+################################################################################
    +CINCLUDES-$(CONFIG_LIBFXDIV) += -I$(LIBFXDIV_SRC)/include
    +CINCLUDES-$(CONFIG_LIBFXDIV) += -I$(LIBFXDIV_BASE)/include
    +CXXINCLUDES-$(CONFIG_LIBFXDIV) += -I$(LIBFXDIV_SRC)/include
    +CXXINCLUDES-$(CONFIG_LIBFXDIV) += -I$(LIBFXDIV_BASE)/include
    +
    
+################################################################################
    +# Global flags
    
+################################################################################
    +# Suppress some warnings to make the build process look neater
    +SUPPRESS_FLAGS += -Wno-unused-parameter -Wno-unused-variable -Wno-nonnull  
\
    +-Wno-unused-but-set-variable -Wno-unused-label -Wno-char-subscripts        
        \
    +-Wno-unused-function -Wno-missing-field-initializers -Wno-uninitialized    
        \
    +-Wno-array-bounds -Wno-maybe-uninitialized -Wno-pointer-sign 
-Wno-unused-value     \
    +-Wno-unused-macros -Wno-parentheses -Wno-implicit-function-declaration     
        \
    +-Wno-missing-braces -Wno-endif-labels -Wno-unused-but-set-variable         
\
    +-Wno-implicit-function-declaration -Wno-type-limits -Wno-sign-compare
    +LIBFXDIV_CFLAGS-y    +=  $(SUPPRESS_FLAGS)
    +LIBFXDIV_CXXFLAGS-y    +=  $(SUPPRESS_FLAGS)
    +
    diff --git a/exportsyms.uk b/exportsyms.uk
    new file mode 100644
    index 0000000..621e94f
    --- /dev/null
    +++ b/exportsyms.uk
    @@ -0,0 +1 @@
    +none
    -- 
    2.21.0
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel