Re: [Minios-devel] [UNIKRAFT/CLICK PATCH 01/11] Initial public release: basic unikraft files

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Florian,

On 04.06.19, 17:17, "Florian Schmidt" <Florian.Schmidt@xxxxxxxxx> wrote:

    
    On 6/4/19 4:01 PM, Felipe Huici wrote:
    > Hi Florian,
    > 
    > Thanks for the series! Regarding this patch:
    > 
    > * The license headers are missing
    
    For Makefile.uk you mean? I'll add it.
    
    > * The .md files are missing
    
    Right, I'll add them
    
    > * When configuring lwip, I noticed that if the option "Automatically 
attach netifs" is selected, the router fails to initialize ("Failed to 
configure device", from click.cc). Could you please unselect this by adding an 
option in Config.uk?
    
    This is a bit more tricky, because there's no "deselect" functionality 
    in kconfig. It also is probably very confusing to do a "depends on 
    !LWIP_AUTOIFACE", because it's not very clear in menuconfig why you 
    suddenly can't enable and choose options for click any more.
    
    The next best thing, even though slightly ugly, might be to add a check 
    to Click's Makefile.uk that stops the build with an error message if 
    LWIP_AUTOIFACE is selected.

Yes, I meant the latter option, please add this.

Thanks,

-- Felipe
    
    Cheers,
    Florian
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel