Re: [Minios-devel] [UNIKRAFT PATCH v2 3/5] lib/vfscore: check return value of vfs_write in sys_write

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Reviewed-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>

On 6/3/19 11:04 AM, Yuri Volchkov wrote:
> This check has been lost during the porting.
>
> Signed-off-by: Yuri Volchkov <yuri.volchkov@xxxxxxxxx>
> ---
>   lib/vfscore/syscalls.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vfscore/syscalls.c b/lib/vfscore/syscalls.c
> index 1301f351..385d90c0 100644
> --- a/lib/vfscore/syscalls.c
> +++ b/lib/vfscore/syscalls.c
> @@ -330,7 +330,7 @@ sys_write(struct vfscore_file *fp, const struct iovec *iov, 
> size_t niov,
>         uio.uio_offset = offset;
>         uio.uio_resid = bytes;
>         uio.uio_rw = UIO_WRITE;
> -       vfs_write(fp, &uio, (offset == -1) ? 0 : FOF_OFFSET);
> +       error = vfs_write(fp, &uio, (offset == -1) ? 0 : FOF_OFFSET);
>         *count = bytes - uio.uio_resid;
>   
>   	free(copy_iov);
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel