Re: [Minios-devel] [UNIKRAFT/PTHREAD-EMBEDDED PATCH 6/8] Disable atomic functions

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Costin,

On 6/3/19 8:59 AM, Costin Lupu wrote:
> On 6/3/19 10:32 AM, Florian Schmidt wrote:
> > Hi Costin,
> >
> > On 4/15/19 1:43 PM, Costin Lupu wrote:
> > > We disable the atomic function given that we are using them as macros.
> > >
> > > Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
> > > ---
> > >    pte_osal.c | 3 +++
> > >    1 file changed, 3 insertions(+)
> > >
> > > diff --git a/pte_osal.c b/pte_osal.c
> > > index 8565f49..6be62e3 100644
> > > --- a/pte_osal.c
> > > +++ b/pte_osal.c
> > > @@ -446,6 +446,8 @@ pte_osResult
> > > pte_osSemaphoreCancellablePend(pte_osSemaphoreHandle h,
> > >        return result;
> > >    }
> > >    +#if 0
> > > +/* We use macros instead */
> > So, in contrast to the last patch, where I said it was, in the patch,
> > probably a question of preference whether to keep the code commented out
> > or remove it, I think here it would be actually better to indeed remove
> > it. For the previous patch, it was changes to the original code, so I
> > don't feel strongly either way. But this is our own glue code, and you
> > have completely replaced the functions, so I don't think there's any
> > point of keeping this part around as a comment; it would be different if
> > this was a not-yet-implemented part that might need to be adapted later:
> > I don't think we'll ever practically use this commented-out code, so it
> > might as well go and make the source file more concise. (Plus, there's
> > always a code in the git history if we really need it unexpectedly at
> > some point).
> There is actually a reason why I chose it this way. If the origin code
> gets fixed then we'll be able to use these functions. It doesn't hurt if
> we keep it.
OK, alright. I'm not sure I agree 100%, because I tend to just pick 
those things out of the git repo if I ever need them again, but it's 
just a short amount of code anyway that doesn't bloat the file too much, 
so we can just keep it as it is now, I'm fine with that.
Cheers,
Florian

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel