Re: [Minios-devel] [UNIKRAFT/LIBUNWIND PATCH] Fix some of the compiling warnings

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Costin,

This patch looks good.

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>


On 02.06.19, 15:27, "Costin Lupu" <costin.lupu@xxxxxxxxx> wrote:

    This patch removes the "unused-parameter" warnings generated by the origin 
code
    and the multiple definition warnings for _LIBUNWIND_BUILD_ZERO_COST_APIS 
macro.
    
    Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
    ---
     Makefile.uk | 6 +++++-
     1 file changed, 5 insertions(+), 1 deletion(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index a80a4fe..109e5e8 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -75,11 +75,15 @@ CXXINCLUDES-$(CONFIG_LIBUNWIND) += 
-I$(LIBUNWIND_SRC)/include
     
################################################################################
     CONFIG_FLAGS   += -D _LIBUNWIND_HAS_NO_THREADS  -D __ELF__  -D 
_LIBUNWIND_IS_NATIVE_ONLY           \
                  -D _LIBUNWIND_SUPPORT_DWARF_UNWIND -D _LIBUNWIND_IS_BAREMETAL 
                        \
    -             -D _LIBUNWIND_BUILD_ZERO_COST_APIS -D 
_LIBUNWIND_TARGET_X86_64 -D __x86_64__
    +             -D _LIBUNWIND_TARGET_X86_64 -D __x86_64__
     
     LIBUNWIND_CFLAGS-y      +=  $(CONFIG_FLAGS)
     LIBUNWIND_CXXFLAGS-y    +=  $(CONFIG_FLAGS)
     
    +SUPPRESS_FLAGS += -Wno-unused-parameter
    +LIBUNWIND_CFLAGS-y   += $(SUPPRESS_FLAGS)
    +LIBUNWIND_CXXFLAGS-y += $(SUPPRESS_FLAGS)
    +
     
################################################################################
     # Library sources
     
################################################################################
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel