Re: [Minios-devel] [UNIKRAFT PATCH v5 1/1] build: always produce 2 images: w/ and w/o debug syms

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Hi,

Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:

> Hey Yuri,
>
> I applied your patch but faced still a couple of problems with the 
> updated `Linker.uk` files. The Xen Arm32 build broke even. See my 
> comments inline.
Arm32 is broken not because of this patch. Unless you really find
something new. Could you please check without the patch and compare
results?

> The rest should be fine.
>
> Thanks a lot,
>
> Simon
>
> On 29.05.19 19:17, Yuri Volchkov wrote:
>>                   $(KVM_LD_SCRIPT_FLAGS) \
>> -                 $@.o -o $@)
>> -ifeq ($(CONFIG_OPTIMIZE_DBGFILE),y)
>> -    $(call build_cmd,OBJCOPY,,$@.dbg,\
>> -           $(OBJCOPY) --only-keep-debug $@ $@.dbg)
>> -endif
>> +                 $@.o -o $@.dbg)
>> +    $(call verbose_cmd,SCSTRIP,$(notdir $@),\
>> +            $(SCRIPTS_DIR)/sect-strip.py \
>> +                    $(SECT_STRIP_FLAGS) $(SECT_STRIP_FLAGS-y) \
>> +                    --with-objcopy=$(OBJCOPY) \
>> +                    $@.dbg -o $@)
>> +    $(call verbose_cmd,STRIP,$(notdir $@), $(STRIP) $@)
>
> Running the strip command has to be called after the following `NM` 
> call. Otherwise the `.sym` files are empty. Can you keep `-s` parameter 
> as it was before?:
>    $(call verbose_cmd,STRIP,$(notdir $@),$(STRIP) -s $@)

Indeed it is a mistake. Good catch. I just need to run nm on *.dbg
image. And order actually does not matter.

And you are right about -s option.
>
>>                   $(XEN_LD_SCRIPT_FLAGS) \
>> -                 $@.o -o $@.elf)
>> -ifeq ($(CONFIG_OPTIMIZE_DBGFILE),y)
>> -    $(call build_cmd,OBJCOPY,,$@.dbg,\
>> -           $(OBJCOPY) --only-keep-debug $@.elf $@.dbg)
>> -endif
>> +                 $@.o -o $@.elf.dbg)
>> +    $(call verbose_cmd,SCSTRIP,$(notdir $@.elf),\
>> +            $(SCRIPTS_DIR)/sect-strip.py \
>> +                    $(SECT_STRIP_FLAGS) $(SECT_STRIP_FLAGS-y) \
>> +                    --with-objcopy=$(OBJCOPY) \
>> +                    $@.elf.dbg -o $@.elf)
>> +    $(call verbose_cmd,STRIP,$(notdir $@.elf), $(STRIP) -o $@.elf)
>
> The `-o` option is incorrect for the strip command. `strip` fails with 
> invalid arguments; use `-s`. Same problem with the `.sym` file order.
>
I don't understand.

  $ strip --help
  Usage: strip <option(s)> in-file(s)
  Removes symbols and sections from files
  The options are:
      ...
  -s --strip-all                   Remove all symbol and relocation information
      ...
  -o <file>                        Place stripped output into <file>
  
The -o looks correct to me. And what does '-s' has to do with '-o'?

-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel