Re: [Minios-devel] [UNIKRAFT PATCH] build: Remove unnecessary /plat/Linker.uk

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon,

The patch looks good, I might fix the commit message a bit on upstream.

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 23.05.19, 16:12, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    Since commit 9e3470a6a, `/plat/Linker.uk` is including platform's
    `Linker.uk` files by iterating over `$(UK_PLAT)` variable. Because
    this code stays the same independent of platforms are going to be
    added or removed, we move the iteration to the core Makefile.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     Makefile       | 3 ++-
     plat/Linker.uk | 1 -
     2 files changed, 2 insertions(+), 2 deletions(-)
     delete mode 100644 plat/Linker.uk
    
    diff --git a/Makefile b/Makefile
    index 5846a772..c0492920 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -512,7 +512,8 @@ ifneq ($(call qstrip,$(UK_DEPS) $(UK_DEPS-y)),)
     -include $(UK_DEPS) $(UK_DEPS-y) # include header dependencies
     endif
     
    -include $(CONFIG_UK_BASE)/plat/Linker.uk
    +# include Makefile for platform linking (`Linker.uk`)
    +$(foreach plat,$(UK_PLATS),$(eval $(call _import_linker,$(plat))))
     
     .PHONY: prepare image libs objs clean
     
    diff --git a/plat/Linker.uk b/plat/Linker.uk
    deleted file mode 100644
    index f80c7ae6..00000000
    --- a/plat/Linker.uk
    +++ /dev/null
    @@ -1 +0,0 @@
    -$(foreach plat,$(UK_PLATS),$(eval $(call _import_linker,$(plat))))
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel