Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH 2/6] Glue code for some user-related libc functions

[Florian Schmidt <Florian.Schmidt@xxxxxxxxx>]

Hi Felipe,

On 5/27/19 2:03 PM, Felipe Huici wrote:
> Hi Florian,
>
> getuid() is now provided by the optional ukunistd library. Would you mind 
> please compile-guarding the implementation in this patch? Otherwise, as is the 
> case when applying this patch series, enabling ukunistd results in multiple 
> definition errors.
Ah, right. Actually, I might just remove getuid completely in that case. 
The only point was to provide a stub for applications that need it, and 
if there's now a a unikraft-internval library for that, an application 
should just include that one, I think. No need for a compile-guard even.
Cheers,
Florian

> Thanks,
>
> -- Felipe
>
> On 20.05.19, 13:31, "Minios-devel on behalf of Florian Schmidt" 
> <minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of florian.schmidt@xxxxxxxxx> wrote:
>
>      Signed-off-by: Florian Schmidt <florian.schmidt@xxxxxxxxx>
>      ---
>       Makefile.uk |  1 +
>       user.c      | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>       2 files changed, 52 insertions(+)
>       create mode 100644 user.c
>      
>      diff --git a/Makefile.uk b/Makefile.uk
>      index 82e4e6e..4de23e9 100644
>      --- a/Makefile.uk
>      +++ b/Makefile.uk
>      @@ -113,6 +113,7 @@ LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/resource.c
>       LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/pty.c
>       LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/time.c|glue
>       LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/locale.c
>      +LIBNEWLIBGLUE_SRCS-y += $(LIBNEWLIBC_BASE)/user.c
>       
>       ################################################################################
>       # Newlib/libc code -- argz
>      diff --git a/user.c b/user.c
>      new file mode 100644
>      index 0000000..33065b4
>      --- /dev/null
>      +++ b/user.c
>      @@ -0,0 +1,51 @@
>      +/* SPDX-License-Identifier: BSD-3-Clause */
>      +/*
>      + * libnewlib glue code
>      + *
>      + * Authors: Florian Schmidt <florian.schmidt@xxxxxxxxx>
>      + *
>      + * Copyright (c) 2019, NEC Europe Ltd., NEC Corporation. All rights 
> reserved.
>      + *
>      + * Redistribution and use in source and binary forms, with or without
>      + * modification, are permitted provided that the following conditions
>      + * are met:
>      + *
>      + * 1. Redistributions of source code must retain the above copyright
>      + *    notice, this list of conditions and the following disclaimer.
>      + * 2. Redistributions in binary form must reproduce the above copyright
>      + *    notice, this list of conditions and the following disclaimer in the
>      + *    documentation and/or other materials provided with the distribution.
>      + * 3. Neither the name of the copyright holder nor the names of its
>      + *    contributors may be used to endorse or promote products derived from
>      + *    this software without specific prior written permission.
>      + *
>      + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> IS"
>      + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
> THE
>      + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
> PURPOSE
>      + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
> BE
>      + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>      + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>      + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR 
> BUSINESS
>      + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>      + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>      + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
> THE
>      + * POSSIBILITY OF SUCH DAMAGE.
>      + *
>      + * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>      + */
>      +
>      +#include <errno.h>
>      +#include <pwd.h>
>      +
>      +/* No password file available */
>      +struct passwd *getpwnam(const char *name __unused)
>      +{
>      +  errno = EIO;
>      +  return NULL;
>      +}
>      +
>      +/* In our unikernel, we're always what amounts to root */
>      +uid_t getuid(void)
>      +{
>      +  return 0;
>      +}
>      --
>      2.21.0
>      
>      
>      _______________________________________________
>      Minios-devel mailing list
>      Minios-devel@xxxxxxxxxxxxxxxxxxxx
>      https://lists.xenproject.org/mailman/listinfo/minios-devel
--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel