Re: [Minios-devel] [UNIKRAFT PATCH] lib/nolibc: Provide `ar.h` header

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon,

This patch also looks good.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 17.04.19, 15:01, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    `ar.h` defines macros and data types for working with archive files
    created with the Unix `ar` tool. The header is ported from FreeBSD.
    
    The motivation to add it to nolibc is to make it possible to create
    simple and flat ar-based filesystems for Unikraft with
    nolibc. Furthermore, it does not introduce any costs: Adding `ar.h`
    does not introduce any symbols to nolibc. It also seems to be usual
    that libc's ship this header as one can see on other libc implementations
    (e.g., newlib, musl, glibc).
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     lib/nolibc/include/ar.h | 72 +++++++++++++++++++++++++++++++++++++++++
     1 file changed, 72 insertions(+)
     create mode 100644 lib/nolibc/include/ar.h
    
    diff --git a/lib/nolibc/include/ar.h b/lib/nolibc/include/ar.h
    new file mode 100644
    index 00000000..22edb915
    --- /dev/null
    +++ b/lib/nolibc/include/ar.h
    @@ -0,0 +1,72 @@
    +/*-
    + * SPDX-License-Identifier: BSD-3-Clause
    + *
    + * Copyright (c) 1991, 1993
    + * The Regents of the University of California.  All rights reserved.
    + * (c) UNIX System Laboratories, Inc.
    + * All or some portions of this file are derived from material licensed
    + * to the University of California by American Telephone and Telegraph
    + * Co. or Unix System Laboratories, Inc. and are reproduced herein with
    + * the permission of UNIX System Laboratories, Inc.
    + *
    + * This code is derived from software contributed to Berkeley by
    + * Hugh Smith at The University of Guelph.
    + *
    + * Redistribution and use in source and binary forms, with or without
    + * modification, are permitted provided that the following conditions
    + * are met:
    + * 1. Redistributions of source code must retain the above copyright
    + *    notice, this list of conditions and the following disclaimer.
    + * 2. Redistributions in binary form must reproduce the above copyright
    + *    notice, this list of conditions and the following disclaimer in the
    + *    documentation and/or other materials provided with the distribution.
    + * 3. Neither the name of the University nor the names of its contributors
    + *    may be used to endorse or promote products derived from this software
    + *    without specific prior written permission.
    + *
    + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
    + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
    + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE
    + * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
    + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
    + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
    + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
    + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, 
STRICT
    + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY 
WAY
    + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
    + * SUCH DAMAGE.
    + *
    + * @(#)ar.h        8.2 (Berkeley) 1/21/94
    + *
    + * $FreeBSD$
    + */
    +/* Ported from FreeBSD
    + * https://github.com/freebsd/freebsd.git; commit: ce3b3184323
    + */
    +
    +#ifndef _AR_H_
    +#define    _AR_H_
    +
    +#include <uk/essentials.h>
    +
    +/* Pre-4BSD archives had these magic numbers in them. */
    +#define    OARMAG1 0177555
    +#define    OARMAG2 0177545
    +
    +#define    ARMAG           "!<arch>\n"     /* ar "magic number" */
    +#define    SARMAG          8               /* strlen(ARMAG); */
    +
    +#define    AR_EFMT1        "#1/"           /* extended format #1 */
    +
    +struct ar_hdr {
    +   char ar_name[16];               /* name */
    +   char ar_date[12];               /* modification time */
    +   char ar_uid[6];                 /* user id */
    +   char ar_gid[6];                 /* group id */
    +   char ar_mode[8];                /* octal file permissions */
    +   char ar_size[10];               /* size in bytes */
    +#define    ARFMAG  "`\n"
    +   char ar_fmag[2];                /* consistency check */
    +} __packed;
    +
    +#endif /* !_AR_H_ */
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel