Re: [Minios-devel] [UNIKRAFT PATCH 0/6] Import devfs from OSv

[Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>]

Hey Yuri,

Thank you for the review. I'll make the proposed changes to the v2 of 
the patch

Regards,

Vlad

On 4/18/19 4:51 PM, Yuri Volchkov wrote:
> Thanks again for the series.
>
> As more general note, please fix compilation warnings. Including the
> case when DEBUG_DEVFS and UK_DEBUG are defined
>
> Kind regards, Yuri.
>
> "Vlad-Andrei BĂDOIU (78692)" <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> writes:
>
>> This patch series is similar to the ramfs one.
>> Since devfs had almost no C++ code the codesbase
>> is only slightly modified.
>>
>> Vlad-Andrei Badoiu (6):
>>    lib/devfs: Initial import from OSv
>>    lib/vfscore: Import device.h from OSv
>>    lib/devfs: Adapt imported devfs to Unikraft
>>    lib/devfs: Tabify imported devfs code
>>    lib/devfs: Fix checkpath warnings
>>    lib/devfs: Update license header for the imported files
>>
>>   lib/Config.uk                        |   1 +
>>   lib/Makefile.uk                      |   1 +
>>   lib/devfs/Config.uk                  |   4 +
>>   lib/devfs/Makefile.uk                |   4 +
>>   lib/devfs/devfs.h                    |  40 +++
>>   lib/devfs/devfs_vnops.c              | 360 ++++++++++++++++++++++++
>>   lib/devfs/device.c                   | 401 +++++++++++++++++++++++++++
>>   lib/vfscore/include/vfscore/device.h | 213 ++++++++++++++
>>   8 files changed, 1024 insertions(+)
>>   create mode 100644 lib/devfs/Config.uk
>>   create mode 100644 lib/devfs/Makefile.uk
>>   create mode 100644 lib/devfs/devfs.h
>>   create mode 100644 lib/devfs/devfs_vnops.c
>>   create mode 100644 lib/devfs/device.c
>>   create mode 100644 lib/vfscore/include/vfscore/device.h
>>
>> -- 
>> 2.20.1
>>
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel