Re: [Minios-devel] [UNIKRAFT PATCH 2/6] lib/vfscore: Import device.h from OSv

[Yuri Volchkov <yuri.volchkov@xxxxxxxxx>]

Understood.

But OSv is a bit different story. The devfs is part of the os and can
not be removed. On contrary, in Unikraft it is a library, which can be
disabled in menuconfig.

As you mentioned not all of vfscore files are originally from
'osv/fs/vfs' directory, but from other places in OSv. However, it sounds
logical to me that files responsible for vfs implementation and
definitions went to the vfscore library. Simply to keep modular
structure of the sources.

I think that the same principle applies to the devfs - we better keep
its files together.


"Vlad-Andrei BĂDOIU (78692)" <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
writes:

> Hey Yuri,
>
> The guys from OSv don't keep the file in devfs, as you can see here[1], 
> but under osv/include/osv/ . I've followed the previous vfscore patches 
> where the headers under osv/include/osv went in vfscore/include/vfscore.
>
> Vlad
>
> [1] https://github.com/cloudius-systems/osv/tree/master/fs/devfs
>
> [2]


-- 
Yuri Volchkov
Software Specialist

NEC Europe Ltd
Kurfürsten-Anlage 36
D-69115 Heidelberg

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel