Re: [Minios-devel] [UNIKRAFT PATCHv4 0/9] Add frequently usd APIs to fdt(series#2)

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Jia He,

Thank you for this patch series. The following patches had some change 
requested:
#1
#2
#4
#5 (minor comments)
#6
#7
#8

Thanks & Regards
Sharan


On 4/2/19 4:40 AM, Jia He wrote:
> Hi, ping
>
> ---
> Cheers,
> Justin (Jia He)
>
> On 2019/3/27 10:34, Jia He wrote:
> > Arm64 devices libraries will access device tree to get lots of
> > properties. We will get device addresses, interrupts in each device
> > library. In this case, we will find device node by offset, get address
> > cells, size cells and interrupt cells everywhere.
> >
> > This patch series introduces serveral APIs in lib/fdt to reduce the
> > redundant calls of fdt functions.
> > ---
> > Changes:
> > v3->v4: address the comments from Julien.
> >    1.add fdt translate address patch05 to handle the "ranges" property
> >    2.add fdt_{address,size}_cells_or_parent helpers patch04
> >    3.fix a default value bug which doesn't follow DT spec
> > v2->v3: address the comments from Julien.
> >    1.remove fdt_get_cells to keep libfdt unchanged
> >    2.parse "interrupt-extended" and "ranges"
> >    3.remove the size parameter in fdt_node_offset_by_compatible_list
> >    4.remove the fdt_for_each_compatible_node which is not used.
> > v1->v2: rebase to latest code.
> >
> > Jia He (7):
> >    plat/kvm: Add build support for internal fdt interfaces
> >    plat/common: Introduce fdt_{address,size}_cells_or_parent helpers
> >    plat/common: Add fdt address translation support
> >    plat/common: Introduce fdt_get_address helper
> >    plat/common: Introduce fdt_node_offset_by_compatible_list helper
> >    plat/common: Introduce fdt_get_interrupt helper
> >    lib/fdt: Change the default value of fdt_size_cells
> >
> > Jianyong Wu (1):
> >    plat/common: Introduce fdt_getprop_u32_by_offset helper
> >
> > Wei Chen (1):
> >    plat/common: Introduce fdt_interrupt_cells helper to parse irq
> >
> >   lib/fdt/fdt_addresses.c   |   2 +-
> >   lib/fdt/include/libfdt.h  |   2 +-
> >   plat/common/fdt.c         | 373 ++++++++++++++++++++++++++++++++++++++
> >   plat/common/include/fdt.h | 170 +++++++++++++++++
> >   plat/kvm/Makefile.uk      |   2 +
> >   5 files changed, 547 insertions(+), 2 deletions(-)
> >   create mode 100644 plat/common/fdt.c
> >   create mode 100644 plat/common/include/fdt.h
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel