Re: [Minios-devel] [UNIKRAFT/LIBNEWLIB PATCH] Suppress code style warnings when using GCC 6, 7 or 8

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon,

Looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 10.04.19, 11:27, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    Supress code style warnings for external libnewlib sources when using
    GCC 6, GCC 7, or GCC 8. The new warning suppression flags are
    introduced depending on the GCC version that is in use.
    Additionally, this patch name spaces `SUPPRESS_FLAGS` to
    `LIBNEWLIB_SUPPRESS_FLAGS-y` and we remove the double definition of
    `-Wno-implicit-function-declaration`.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     Makefile.uk | 16 ++++++++++------
     1 file changed, 10 insertions(+), 6 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 5635f44..82e4e6e 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -84,18 +84,22 @@ LIBNEWLIBM_CXXINCLUDES += -I$(LIBNEWLIB_LIBM)/common
     LIBNEWLIBC_CFLAGS-y       += -DMISSING_SYSCALL_NAMES -DMALLOC_PROVIDED
     
     # Suppress some warnings to make the build process look neater
    -SUPPRESS_FLAGS += -Wno-unused-parameter -Wno-unused-variable -Wno-nonnull  
\
    +LIBNEWLIB_SUPPRESS_FLAGS-y += \
    +-Wno-unused-parameter -Wno-unused-variable -Wno-nonnull                    
        \
     -Wno-unused-but-set-variable -Wno-unused-label -Wno-char-subscripts        
        \
     -Wno-unused-function -Wno-missing-field-initializers -Wno-uninitialized    
        \
     -Wno-array-bounds -Wno-maybe-uninitialized -Wno-pointer-sign 
-Wno-unused-value     \
     -Wno-unused-macros -Wno-parentheses -Wno-implicit-function-declaration     
        \
     -Wno-missing-braces -Wno-endif-labels -Wno-unused-but-set-variable         
\
    --Wno-implicit-function-declaration -Wno-type-limits -Wno-sign-compare
    +-Wno-type-limits -Wno-sign-compare
    +LIBNEWLIB_SUPPRESS_FLAGS-$(call gcc_version_ge,6,0) += 
-Wno-misleading-indentation
    +LIBNEWLIB_SUPPRESS_FLAGS-$(call gcc_version_ge,6,0) += 
-Wno-shift-negative-value
    +LIBNEWLIB_SUPPRESS_FLAGS-$(call gcc_version_ge,7,0) += 
-Wno-implicit-fallthrough
     
    -LIBNEWLIBC_CFLAGS-y   += $(SUPPRESS_FLAGS)
    -LIBNEWLIBM_CFLAGS-y   += $(SUPPRESS_FLAGS)
    -LIBNEWLIBC_CXXFLAGS-y += $(SUPPRESS_FLAGS)
    -LIBNEWLIBM_CXXFLAGS-y += $(SUPPRESS_FLAGS)
    +LIBNEWLIBC_CFLAGS-y   += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
    +LIBNEWLIBM_CFLAGS-y   += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
    +LIBNEWLIBC_CXXFLAGS-y += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
    +LIBNEWLIBM_CXXFLAGS-y += $(LIBNEWLIB_SUPPRESS_FLAGS-y)
     
     
################################################################################
     # OS dependencies code - Glue between Unicore and newlib
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel